From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17409 invoked by alias); 16 Feb 2011 10:24:33 -0000 Received: (qmail 17401 invoked by uid 22791); 16 Feb 2011 10:24:33 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 16 Feb 2011 10:24:27 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p1GAOMS8006139 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 16 Feb 2011 05:24:23 -0500 Received: from hase (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p1GAOLuE014514; Wed, 16 Feb 2011 05:24:21 -0500 From: Andreas Schwab To: Ken Werner Cc: "Ulrich Weigand" , gdb-patches@sourceware.org Subject: Re: [patch] OpenCL datatypes test fixes References: <201102152101.p1FL1tt5009248@d06av02.portsmouth.uk.ibm.com> <201102161108.54061.ken@linux.vnet.ibm.com> X-Yow: Used staples are good with SOY SAUCE! Date: Wed, 16 Feb 2011 10:33:00 -0000 In-Reply-To: <201102161108.54061.ken@linux.vnet.ibm.com> (Ken Werner's message of "Wed, 16 Feb 2011 11:08:54 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00360.txt.bz2 Ken Werner writes: > On Tuesday, February 15, 2011 10:01:55 pm Ulrich Weigand wrote: >> Ken Werner wrote: >> > -gdb_test "whatis c2" "type = char \\\[2\\\]" >> > +gdb_test "whatis c2" "type = char2|char \\\[2\\\]" >> >> Don't we need some parentheses here (and everywere you've >> introduced alternatives via |)? Otherwise, it seems that >> this would stop working with the older compilers ... > > Hi Ulrich, > > Thanks for looking into this patch. Sometimes the GDB testsuite is a mystery > to me. This time it seems to work without parentheses: > > old compiler: > whatis c2 > type = char [2] > (gdb) PASS: gdb.opencl/datatypes.exp: whatis c2 > > new compiler: > whatis c2 > type = char2 > (gdb) PASS: gdb.opencl/datatypes.exp: whatis c2 > > Any suggestions? This passes because "char \\\[2\\\]" matches (a substring of) the first output, but you really want to match the whole string "type = char [2]". +gdb_test "whatis c2" "type = char(2| \\\[2\\\])" Andreas. -- Andreas Schwab, schwab@redhat.com GPG Key fingerprint = D4E8 DBE3 3813 BB5D FA84 5EC7 45C6 250E 6F00 984E "And now for something completely different."