From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: ken@linux.vnet.ibm.com (Ken Werner)
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] OpenCL datatypes test fixes
Date: Tue, 15 Feb 2011 21:06:00 -0000 [thread overview]
Message-ID: <201102152101.p1FL1tt5009248@d06av02.portsmouth.uk.ibm.com> (raw)
In-Reply-To: <201102152100.48256.ken@linux.vnet.ibm.com> from "Ken Werner" at Feb 15, 2011 09:00:48 PM
Ken Werner wrote:
> -gdb_test "whatis c2" "type = char \\\[2\\\]"
> +gdb_test "whatis c2" "type = char2|char \\\[2\\\]"
Don't we need some parentheses here (and everywere you've
introduced alternatives via |)? Otherwise, it seems that
this would stop working with the older compilers ...
Otherwise, this looks good to me.
Thanks,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com
next prev parent reply other threads:[~2011-02-15 21:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-15 20:11 Ken Werner
2011-02-15 21:06 ` Ulrich Weigand [this message]
2011-02-16 10:15 ` Ken Werner
2011-02-16 10:24 ` Jan Kratochvil
2011-02-16 10:33 ` Andreas Schwab
2011-02-16 13:03 ` Ken Werner
2011-02-16 13:55 ` Ulrich Weigand
2011-02-16 14:31 ` Ken Werner
2011-02-16 14:40 ` Ulrich Weigand
2011-02-16 15:38 ` Ken Werner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201102152101.p1FL1tt5009248@d06av02.portsmouth.uk.ibm.com \
--to=uweigand@de.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=ken@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox