From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17640 invoked by alias); 15 Feb 2011 21:02:07 -0000 Received: (qmail 17629 invoked by uid 22791); 15 Feb 2011 21:02:06 -0000 X-SWARE-Spam-Status: No, hits=-1.3 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,SPF_SOFTFAIL,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mtagate4.uk.ibm.com (HELO mtagate4.uk.ibm.com) (194.196.100.164) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 15 Feb 2011 21:02:00 +0000 Received: from d06nrmr1707.portsmouth.uk.ibm.com (d06nrmr1707.portsmouth.uk.ibm.com [9.149.39.225]) by mtagate4.uk.ibm.com (8.13.1/8.13.1) with ESMTP id p1FL1vSF022148 for ; Tue, 15 Feb 2011 21:01:57 GMT Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by d06nrmr1707.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p1FL23sN1790116 for ; Tue, 15 Feb 2011 21:02:03 GMT Received: from d06av02.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p1FL1u08009256 for ; Tue, 15 Feb 2011 14:01:57 -0700 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with SMTP id p1FL1tt5009248; Tue, 15 Feb 2011 14:01:55 -0700 Message-Id: <201102152101.p1FL1tt5009248@d06av02.portsmouth.uk.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Tue, 15 Feb 2011 22:01:55 +0100 Subject: Re: [patch] OpenCL datatypes test fixes To: ken@linux.vnet.ibm.com (Ken Werner) Date: Tue, 15 Feb 2011 21:06:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <201102152100.48256.ken@linux.vnet.ibm.com> from "Ken Werner" at Feb 15, 2011 09:00:48 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00341.txt.bz2 Ken Werner wrote: > -gdb_test "whatis c2" "type = char \\\[2\\\]" > +gdb_test "whatis c2" "type = char2|char \\\[2\\\]" Don't we need some parentheses here (and everywere you've introduced alternatives via |)? Otherwise, it seems that this would stop working with the older compilers ... Otherwise, this looks good to me. Thanks, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com