From: Tom Tromey <tromey@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFA: move value_from_contents_and_address to value.c
Date: Tue, 25 Nov 2008 17:06:00 -0000 [thread overview]
Message-ID: <m3ljv8yalc.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20081124230734.GB3946@adacore.com> (Joel Brobecker's message of "Mon\, 24 Nov 2008 15\:07\:34 -0800")
>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:
>> +struct value *
>> +value_from_contents_and_address (struct type *type,
>> + const gdb_byte *valaddr,
>> + CORE_ADDR address)
Joel> There is a formatting issue in the third line, due to the use of
Joel> spaces instead of tabs. I try to be super careful, now, but I can't
Joel> seem to be able to find a convenient way of configuring my editor
Joel> (vim) for that.
I got a little confused by this, because the third line above does
have tabs. I assume you meant the fourth line, so I'm checking in the
version with tabs on both continuation lines.
FWIW gdbint.texinfo does not mention tabs-vs-spaces.
Tom
next prev parent reply other threads:[~2008-11-24 23:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-21 17:07 Tom Tromey
2008-11-22 12:00 ` Michael Snyder
2008-11-22 18:01 ` Joel Brobecker
2008-11-23 22:12 ` Tom Tromey
2008-11-24 23:16 ` Tom Tromey
2008-11-25 11:49 ` Joel Brobecker
2008-11-25 17:06 ` Tom Tromey [this message]
2008-11-25 18:23 ` Jerome Guitton
2008-11-25 18:38 ` Jerome Guitton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3ljv8yalc.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox