From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFA: move value_from_contents_and_address to value.c
Date: Sat, 22 Nov 2008 18:01:00 -0000 [thread overview]
Message-ID: <20081122050546.GB4318@adacore.com> (raw)
In-Reply-To: <m3skplevf4.fsf@fleche.redhat.com>
Generally speaking, I'm very happy to see the function being moved
out of ada-lang.c.
> +/* Return a new value constructed from some bytes. TYPE is the type
> + of the object. VALADDR is a pointer to the base of the enclosing
> + object. If VALADDR is NULL, the value is marked as lazy.
> + EMBEDDED_OFFSET is the offset into VALADDR of the bytes making up
> + the new object. ADDRESS is the inferior address of the object. */
> +
> +struct value *
> +value_from_contents_and_address (struct type *type, const gdb_byte *valaddr,
> + int embedded_offset, CORE_ADDR address)
I'm wondering whether the offset parameter is really necessary? Would it
be worse to call this function with valaddr+embedded_offset rather
than passing two arguments?
--
Joel
next prev parent reply other threads:[~2008-11-22 5:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-21 17:07 Tom Tromey
2008-11-22 12:00 ` Michael Snyder
2008-11-22 18:01 ` Joel Brobecker [this message]
2008-11-23 22:12 ` Tom Tromey
2008-11-24 23:16 ` Tom Tromey
2008-11-25 11:49 ` Joel Brobecker
2008-11-25 17:06 ` Tom Tromey
2008-11-25 18:23 ` Jerome Guitton
2008-11-25 18:38 ` Jerome Guitton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081122050546.GB4318@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox