From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2315 invoked by alias); 24 Nov 2008 23:22:16 -0000 Received: (qmail 2288 invoked by uid 22791); 24 Nov 2008 23:22:15 -0000 X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 24 Nov 2008 23:21:40 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id mAONL6f5009909; Mon, 24 Nov 2008 18:21:06 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id mAONL5NV010583; Mon, 24 Nov 2008 18:21:05 -0500 Received: from opsy.redhat.com (vpn-12-223.rdu.redhat.com [10.11.12.223]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id mAONL48S029574; Mon, 24 Nov 2008 18:21:04 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id BE3FB378788; Mon, 24 Nov 2008 16:21:03 -0700 (MST) To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: RFA: move value_from_contents_and_address to value.c References: <20081122050546.GB4318@adacore.com> <20081124230734.GB3946@adacore.com> From: Tom Tromey Reply-To: Tom Tromey X-Attribution: Tom Date: Tue, 25 Nov 2008 17:06:00 -0000 In-Reply-To: <20081124230734.GB3946@adacore.com> (Joel Brobecker's message of "Mon\, 24 Nov 2008 15\:07\:34 -0800") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-11/txt/msg00678.txt.bz2 >>>>> "Joel" == Joel Brobecker writes: >> +struct value * >> +value_from_contents_and_address (struct type *type, >> + const gdb_byte *valaddr, >> + CORE_ADDR address) Joel> There is a formatting issue in the third line, due to the use of Joel> spaces instead of tabs. I try to be super careful, now, but I can't Joel> seem to be able to find a convenient way of configuring my editor Joel> (vim) for that. I got a little confused by this, because the third line above does have tabs. I assume you meant the fourth line, so I'm checking in the version with tabs on both continuation lines. FWIW gdbint.texinfo does not mention tabs-vs-spaces. Tom