From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch 4/8] Types GC [varobj_list to all_root_varobjs]
Date: Tue, 09 Jun 2009 20:50:00 -0000 [thread overview]
Message-ID: <m3ljo1i125.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20090525080233.GD13323@host0.dyn.jankratochvil.net> (Jan Kratochvil's message of "Mon\, 25 May 2009 10\:02\:33 +0200")
>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
Jan> this patch is completely optional and it can be dropped, just
Jan> technically the other patches depend on it. I find the callback
Jan> based iterator easier to use, in fact there were bugs due to the
Jan> current calling semantics (`floating' lockup, memory leaks).
It seems reasonable to me, though it would be nice to have Volodya's
approval.
Details on the bugs that this fixes would be nice.
A test case would also be nice, assuming these are testable.
Tom
next prev parent reply other threads:[~2009-06-09 20:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-25 8:02 Jan Kratochvil
2009-06-09 20:50 ` Tom Tromey [this message]
2009-07-02 8:39 ` Jan Kratochvil
2009-07-02 10:09 ` Vladimir Prus
2009-07-04 21:11 ` Jan Kratochvil
2009-07-07 8:54 ` Vladimir Prus
2009-07-07 9:32 ` Jan Kratochvil
2009-07-10 20:17 ` [patch 0/4] varobj_list replacement [Re: [patch 4/8] Types GC [varobj_list to all_root_varobjs]] Jan Kratochvil
2009-07-29 21:34 ` Tom Tromey
2009-07-30 8:46 ` Vladimir Prus
2009-07-30 14:00 ` Jan Kratochvil
2009-07-30 15:13 ` Vladimir Prus
2009-07-30 15:16 ` Jan Kratochvil
2009-07-10 20:18 ` [patch 1/4] varobj_list replacement, choice 1 of 3: VEC_safe_push + VEC_unordered_remove Jan Kratochvil
2009-07-10 20:21 ` [patch 2/4] varobj_list replacement, choice 2 of 3: VEC_safe_insert + VEC_ordered_remove Jan Kratochvil
2009-07-10 21:11 ` [patch 3/4] varobj_list replacement, choice 3 of 3: Iterator Jan Kratochvil
2009-07-10 22:12 ` [patch 4/4] varobj_list replacement, choice 3 of 3: Iterator optimization Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3ljo1i125.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox