Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Vladimir Prus <vladimir@codesourcery.com>
To: Tom Tromey <tromey@redhat.com>
Cc: Jan Kratochvil <jan.kratochvil@redhat.com>,  gdb-patches@sourceware.org
Subject: Re: [patch 0/4] varobj_list replacement  [Re: [patch 4/8] Types GC [varobj_list to all_root_varobjs]]
Date: Thu, 30 Jul 2009 08:46:00 -0000	[thread overview]
Message-ID: <200907301045.51541.vladimir@codesourcery.com> (raw)
In-Reply-To: <m31vnzwazh.fsf@fleche.redhat.com>

On Wednesday 29 July 2009 Tom Tromey wrote:

> >>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
> 
> Volodya> Can we just make varobj.c expose vector of varobjs?
> 
> Jan> In general iterators are preferred over direct variable access in
> Jan> modern programming.
> 
> Yeah, but what about in gdb? ;)
> 
> Jan> Still I would prefer:
> Jan> Iterator - so-called "safe" (keeping the next pointer) double link list:
> 
> This patch (assuming it was the 4/4 patch) seemed pretty clean to me.

...

> I understand from other mail that this patch is a prerequisite to the
> type GC work.  However, I don't understand in what way it is needed.  I
> probably missed something... could you either explain it or tell me
> where to look?

In fact, I'm lost the big picture as well. If we want to optimize uninstall_variable,
then the 4/4 patch appears to be the simplest one that does the trick. However, if
that's a part of some bigger story, I'd be interested to understand it.

Thanks,
Volodya


  reply	other threads:[~2009-07-30  6:46 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-25  8:02 [patch 4/8] Types GC [varobj_list to all_root_varobjs] Jan Kratochvil
2009-06-09 20:50 ` Tom Tromey
2009-07-02  8:39   ` Jan Kratochvil
2009-07-02 10:09     ` Vladimir Prus
2009-07-04 21:11       ` Jan Kratochvil
2009-07-07  8:54         ` Vladimir Prus
2009-07-07  9:32           ` Jan Kratochvil
2009-07-10 20:17       ` [patch 0/4] varobj_list replacement [Re: [patch 4/8] Types GC [varobj_list to all_root_varobjs]] Jan Kratochvil
2009-07-29 21:34         ` Tom Tromey
2009-07-30  8:46           ` Vladimir Prus [this message]
2009-07-30 14:00             ` Jan Kratochvil
2009-07-30 15:13               ` Vladimir Prus
2009-07-30 15:16                 ` Jan Kratochvil
2009-07-10 20:18       ` [patch 1/4] varobj_list replacement, choice 1 of 3: VEC_safe_push + VEC_unordered_remove Jan Kratochvil
2009-07-10 20:21       ` [patch 2/4] varobj_list replacement, choice 2 of 3: VEC_safe_insert + VEC_ordered_remove Jan Kratochvil
2009-07-10 21:11       ` [patch 3/4] varobj_list replacement, choice 3 of 3: Iterator Jan Kratochvil
2009-07-10 22:12       ` [patch 4/4] varobj_list replacement, choice 3 of 3: Iterator optimization Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200907301045.51541.vladimir@codesourcery.com \
    --to=vladimir@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox