From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21936 invoked by alias); 9 Jun 2009 20:50:54 -0000 Received: (qmail 21820 invoked by uid 22791); 9 Jun 2009 20:50:54 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 09 Jun 2009 20:50:47 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n59Kojvb004275 for ; Tue, 9 Jun 2009 16:50:45 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n59Koi67020295; Tue, 9 Jun 2009 16:50:45 -0400 Received: from opsy.redhat.com (vpn-12-99.rdu.redhat.com [10.11.12.99]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n59KohAK013406; Tue, 9 Jun 2009 16:50:44 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id D27BD486A3; Tue, 9 Jun 2009 14:50:42 -0600 (MDT) To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [patch 4/8] Types GC [varobj_list to all_root_varobjs] References: <20090525080233.GD13323@host0.dyn.jankratochvil.net> From: Tom Tromey Reply-To: tromey@redhat.com Date: Tue, 09 Jun 2009 20:50:00 -0000 In-Reply-To: <20090525080233.GD13323@host0.dyn.jankratochvil.net> (Jan Kratochvil's message of "Mon\, 25 May 2009 10\:02\:33 +0200") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00244.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: Jan> this patch is completely optional and it can be dropped, just Jan> technically the other patches depend on it. I find the callback Jan> based iterator easier to use, in fact there were bugs due to the Jan> current calling semantics (`floating' lockup, memory leaks). It seems reasonable to me, though it would be nice to have Volodya's approval. Details on the bugs that this fixes would be nice. A test case would also be nice, assuming these are testable. Tom