From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Keith Seitz <keiths@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [rfc 2/2] Follow DW_AT_linkage_name for methods [Re: The future of dwarf2_physname]
Date: Wed, 25 May 2011 20:40:00 -0000 [thread overview]
Message-ID: <m3lixu3461.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20110524212111.GB7747@host1.jankratochvil.net> (Jan Kratochvil's message of "Tue, 24 May 2011 23:21:11 +0200")
>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
Jan> Also after a chat with Tom Tromey I no longer use DMGL_RET_POSTFIX.
Jan> That is for ELF symbol `long m<char>()' GDB with proposed patch
Jan> uses `m<char>()' (and not `m<char>()long'). This is compatible
Jan> with gdb-7.2 (physname) template functions.
This patch looks pretty good to me.
Keith, are there parts of your series which are still needed for 7.3 if
this patch is committed there?
The new command probably needs documentation (it is unclear to me
whether we document, or even whether we should document, "set debug"
commands).
Jan> + canon = (char *) mangled;
I think 'canon' can be made const and this cast reomved.
Tom
next prev parent reply other threads:[~2011-05-25 20:40 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-18 22:35 The future of dwarf2_physname Keith Seitz
2011-05-19 19:23 ` Jan Kratochvil
2011-05-20 19:53 ` Keith Seitz
2011-05-20 20:38 ` Jan Kratochvil
2011-05-20 20:39 ` Tom Tromey
2011-05-21 20:37 ` Daniel Jacobowitz
2011-05-19 21:00 ` Daniel Jacobowitz
2011-05-20 19:26 ` Tom Tromey
2011-05-21 20:34 ` Daniel Jacobowitz
2011-05-20 19:10 ` Tom Tromey
2011-05-23 13:17 ` Jan Kratochvil
2011-05-23 19:52 ` Tom Tromey
2011-05-23 19:57 ` Keith Seitz
2011-05-24 21:12 ` [rfc 1/2] libiberty/ options code reshuffle [Re: The future of dwarf2_physname] Jan Kratochvil
2011-06-02 15:36 ` obsolete: " Jan Kratochvil
2011-05-24 21:21 ` [rfc 2/2] Follow DW_AT_linkage_name for methods " Jan Kratochvil
2011-05-25 19:40 ` Keith Seitz
2011-05-25 20:42 ` Tom Tromey
2011-05-25 20:40 ` Tom Tromey [this message]
2011-06-01 18:35 ` Keith Seitz
2011-06-02 16:26 ` Jan Kratochvil
2011-06-02 18:20 ` Tom Tromey
2011-06-02 18:28 ` Jan Kratochvil
2011-06-02 19:03 ` obsolete: " Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3lixu3461.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=keiths@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox