From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11437 invoked by alias); 25 May 2011 20:40:25 -0000 Received: (qmail 11428 invoked by uid 22791); 25 May 2011 20:40:24 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 25 May 2011 20:40:08 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p4PKe8hB009041 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 25 May 2011 16:40:08 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p4PKe7sV022904; Wed, 25 May 2011 16:40:07 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p4PKe7Wl029770; Wed, 25 May 2011 16:40:07 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id CF6C93781A6; Wed, 25 May 2011 14:40:06 -0600 (MDT) From: Tom Tromey To: Jan Kratochvil Cc: Keith Seitz , gdb-patches@sourceware.org Subject: Re: [rfc 2/2] Follow DW_AT_linkage_name for methods [Re: The future of dwarf2_physname] References: <4DD44983.7060406@redhat.com> <20110523131659.GA30344@host1.jankratochvil.net> <20110524212111.GB7747@host1.jankratochvil.net> Date: Wed, 25 May 2011 20:40:00 -0000 In-Reply-To: <20110524212111.GB7747@host1.jankratochvil.net> (Jan Kratochvil's message of "Tue, 24 May 2011 23:21:11 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-05/txt/msg00589.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: Jan> Also after a chat with Tom Tromey I no longer use DMGL_RET_POSTFIX. Jan> That is for ELF symbol `long m()' GDB with proposed patch Jan> uses `m()' (and not `m()long'). This is compatible Jan> with gdb-7.2 (physname) template functions. This patch looks pretty good to me. Keith, are there parts of your series which are still needed for 7.3 if this patch is committed there? The new command probably needs documentation (it is unclear to me whether we document, or even whether we should document, "set debug" commands). Jan> + canon = (char *) mangled; I think 'canon' can be made const and this cast reomved. Tom