Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Keith Seitz <keiths@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [rfc 2/2] Follow DW_AT_linkage_name for methods  [Re: The future of dwarf2_physname]
Date: Wed, 25 May 2011 19:40:00 -0000	[thread overview]
Message-ID: <4DDD5B19.7010706@redhat.com> (raw)
In-Reply-To: <20110524212111.GB7747@host1.jankratochvil.net>

I don't know if you are waiting on me for a reply on this or not, but I 
thought I would throw out my fractional pennies.

On 05/24/2011 02:21 PM, Jan Kratochvil wrote:
> Also after a chat with Tom Tromey I no longer use DMGL_RET_POSTFIX.  That is
> for ELF symbol `long m<char>()' GDB with proposed patch uses `m<char>()'
> (and not `m<char>()long').  This is compatible with gdb-7.2 (physname)
> template functions.

I am relieved to hear this (mis?)feature is staying put. I'm a practical 
kind of person, and I know I'd really *hate* to have to type "break 'int 
blah<int>(blah)'" every time. Yuck.

As for how to address the (remote?) possibility that we will need a 
return type, I'd like to offer the idea that we might introduce some 
sort of qualifier flag, for example, "break blah<int>/int" or "break/int 
blah<int>" or something along those lines. Of course, this is well 
beyond the scope of 7.3. Just thought I'd toss this out there, though, 
as a starting point should this actually become a problem.

> Anyway DW_AT_linkage_name following patch with no regressions on
> {x86_64,x86_64-m32,i686}-fedora15-linux-gnu is attached.  It would need GCC
> push of the libiberty/ change.

I'll reiterate what I wrote to Tom yesterday, "I'm all for it."

Keith


  reply	other threads:[~2011-05-25 19:40 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-18 22:35 The future of dwarf2_physname Keith Seitz
2011-05-19 19:23 ` Jan Kratochvil
2011-05-20 19:53   ` Keith Seitz
2011-05-20 20:38     ` Jan Kratochvil
2011-05-20 20:39     ` Tom Tromey
2011-05-21 20:37       ` Daniel Jacobowitz
2011-05-19 21:00 ` Daniel Jacobowitz
2011-05-20 19:26   ` Tom Tromey
2011-05-21 20:34     ` Daniel Jacobowitz
2011-05-20 19:10 ` Tom Tromey
2011-05-23 13:17 ` Jan Kratochvil
2011-05-23 19:52   ` Tom Tromey
2011-05-23 19:57     ` Keith Seitz
2011-05-24 21:12   ` [rfc 1/2] libiberty/ options code reshuffle [Re: The future of dwarf2_physname] Jan Kratochvil
2011-06-02 15:36     ` obsolete: " Jan Kratochvil
2011-05-24 21:21   ` [rfc 2/2] Follow DW_AT_linkage_name for methods " Jan Kratochvil
2011-05-25 19:40     ` Keith Seitz [this message]
2011-05-25 20:42       ` Tom Tromey
2011-05-25 20:40     ` Tom Tromey
2011-06-01 18:35       ` Keith Seitz
2011-06-02 16:26         ` Jan Kratochvil
2011-06-02 18:20           ` Tom Tromey
2011-06-02 18:28             ` Jan Kratochvil
2011-06-02 19:03     ` obsolete: " Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DDD5B19.7010706@redhat.com \
    --to=keiths@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox