From: Tom Tromey <tromey@redhat.com>
To: "Ulrich Weigand" <uweigand@de.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [rfc] Work around invalid G++ DWARF for unnamed aggregates
Date: Thu, 25 Mar 2010 20:03:00 -0000 [thread overview]
Message-ID: <m3k4t0dv93.fsf@fleche.redhat.com> (raw)
In-Reply-To: <201003251022.o2PAM3dl017253@d12av02.megacenter.de.ibm.com> (Ulrich Weigand's message of "Thu, 25 Mar 2010 11:22:03 +0100 (CET)")
>>>>> "Ulrich" == Ulrich Weigand <uweigand@de.ibm.com> writes:
Ulrich> It should be easy to work around this problem with older GCC
Ulrich> versions by simply ignoring DW_AT_name attributes with such
Ulrich> names in dwarf2_name. The patch below implements this. It also
Ulrich> fixes a logic bug in completer.c exposed by this change, where
Ulrich> in an unnamed struct *every* method was considered to be a
Ulrich> constructor (instead of none).
[...]
Ulrich> Does this look reasonable?
FWIW, yes, it looks reasonable to me.
Tom
next prev parent reply other threads:[~2010-03-25 20:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-25 10:22 Ulrich Weigand
2010-03-25 20:03 ` Tom Tromey [this message]
2010-03-26 18:07 ` Ulrich Weigand
2010-04-06 12:50 ` [commit] Fix typo (Re: [rfc] Work around invalid G++ DWARF for unnamed aggregates) Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3k4t0dv93.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox