From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19394 invoked by alias); 25 Mar 2010 20:03:29 -0000 Received: (qmail 19330 invoked by uid 22791); 25 Mar 2010 20:03:28 -0000 X-SWARE-Spam-Status: No, hits=-7.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 25 Mar 2010 20:03:24 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o2PK3LKj018287 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 25 Mar 2010 16:03:22 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o2PK3LOp007489; Thu, 25 Mar 2010 16:03:21 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o2PK3Kpw012123; Thu, 25 Mar 2010 16:03:21 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 5BD7F37822D; Thu, 25 Mar 2010 14:03:20 -0600 (MDT) From: Tom Tromey To: "Ulrich Weigand" Cc: gdb-patches@sourceware.org Subject: Re: [rfc] Work around invalid G++ DWARF for unnamed aggregates References: <201003251022.o2PAM3dl017253@d12av02.megacenter.de.ibm.com> Reply-To: tromey@redhat.com Date: Thu, 25 Mar 2010 20:03:00 -0000 In-Reply-To: <201003251022.o2PAM3dl017253@d12av02.megacenter.de.ibm.com> (Ulrich Weigand's message of "Thu, 25 Mar 2010 11:22:03 +0100 (CET)") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg00859.txt.bz2 >>>>> "Ulrich" == Ulrich Weigand writes: Ulrich> It should be easy to work around this problem with older GCC Ulrich> versions by simply ignoring DW_AT_name attributes with such Ulrich> names in dwarf2_name. The patch below implements this. It also Ulrich> fixes a logic bug in completer.c exposed by this change, where Ulrich> in an unnamed struct *every* method was considered to be a Ulrich> constructor (instead of none). [...] Ulrich> Does this look reasonable? FWIW, yes, it looks reasonable to me. Tom