From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: gdb-patches@sourceware.org
Subject: [commit] Fix typo (Re: [rfc] Work around invalid G++ DWARF for unnamed aggregates)
Date: Tue, 06 Apr 2010 12:50:00 -0000 [thread overview]
Message-ID: <201004061249.o36CniYQ019548@d12av02.megacenter.de.ibm.com> (raw)
In-Reply-To: <201003261807.o2QI7ihN030662@d12av02.megacenter.de.ibm.com> from "Ulrich Weigand" at Mar 26, 2010 07:07:44 PM
> * gdb.cp/inherit.exp (test_ptype_si): XFAIL test for GCC versions
> that do not provide the tagless_struct type name at all.
> (test_print_anon_union): Do not check value of uninitialized
> union member. Do not use cp_test_ptype_class, so we can accept
> "long" as well as "long int".
> + set re_class "(class $re_tag \{${ws}public:|struct $re_tag\{)"
The re_class string is missing a space in the "struct" case, which I
just noticed when testing against an old GCC version.
Fixed by the following patch. Tested on powerpc64-linux, committed
to mainline.
Bye,
Ulrich
ChangeLog:
* gdb.cp/inherit.exp (test_print_anon_union): Fix re_class pattern.
Index: gdb/testsuite/gdb.cp/inherit.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.cp/inherit.exp,v
retrieving revision 1.16
diff -u -p -r1.16 inherit.exp
--- gdb/testsuite/gdb.cp/inherit.exp 26 Mar 2010 18:05:46 -0000 1.16
+++ gdb/testsuite/gdb.cp/inherit.exp 6 Apr 2010 12:40:45 -0000
@@ -502,7 +502,7 @@ proc test_print_anon_union {} {
set name "print type of anonymous union"
set re_tag "class_with_anon_union"
- set re_class "(class $re_tag \{${ws}public:|struct $re_tag\{)"
+ set re_class "(class $re_tag \{${ws}public:|struct $re_tag \{)"
set re_fields "int one;${ws}union \{${ws}int a;${ws}long( int)? b;${ws}\};"
gdb_test_multiple "ptype g_anon_union" $name {
-re "type = $re_class${ws}$re_fields$nl\}$nl$gdb_prompt $" {
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com
prev parent reply other threads:[~2010-04-06 12:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-25 10:22 [rfc] Work around invalid G++ DWARF for unnamed aggregates Ulrich Weigand
2010-03-25 20:03 ` Tom Tromey
2010-03-26 18:07 ` Ulrich Weigand
2010-04-06 12:50 ` Ulrich Weigand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201004061249.o36CniYQ019548@d12av02.megacenter.de.ibm.com \
--to=uweigand@de.ibm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox