From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25816 invoked by alias); 6 Apr 2010 12:50:00 -0000 Received: (qmail 25798 invoked by uid 22791); 6 Apr 2010 12:49:56 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=BAYES_00,MSGID_FROM_MTA_HEADER,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mtagate4.de.ibm.com (HELO mtagate4.de.ibm.com) (195.212.17.164) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 06 Apr 2010 12:49:49 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate4.de.ibm.com (8.13.1/8.13.1) with ESMTP id o36CnkGY029959 for ; Tue, 6 Apr 2010 12:49:46 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o36CnkWs1699888 for ; Tue, 6 Apr 2010 14:49:46 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id o36CnjsU019553 for ; Tue, 6 Apr 2010 14:49:46 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id o36CniYQ019548 for ; Tue, 6 Apr 2010 14:49:44 +0200 Message-Id: <201004061249.o36CniYQ019548@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Tue, 06 Apr 2010 14:49:44 +0200 Subject: [commit] Fix typo (Re: [rfc] Work around invalid G++ DWARF for unnamed aggregates) To: gdb-patches@sourceware.org Date: Tue, 06 Apr 2010 12:50:00 -0000 From: "Ulrich Weigand" In-Reply-To: <201003261807.o2QI7ihN030662@d12av02.megacenter.de.ibm.com> from "Ulrich Weigand" at Mar 26, 2010 07:07:44 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00091.txt.bz2 > * gdb.cp/inherit.exp (test_ptype_si): XFAIL test for GCC versions > that do not provide the tagless_struct type name at all. > (test_print_anon_union): Do not check value of uninitialized > union member. Do not use cp_test_ptype_class, so we can accept > "long" as well as "long int". > + set re_class "(class $re_tag \{${ws}public:|struct $re_tag\{)" The re_class string is missing a space in the "struct" case, which I just noticed when testing against an old GCC version. Fixed by the following patch. Tested on powerpc64-linux, committed to mainline. Bye, Ulrich ChangeLog: * gdb.cp/inherit.exp (test_print_anon_union): Fix re_class pattern. Index: gdb/testsuite/gdb.cp/inherit.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.cp/inherit.exp,v retrieving revision 1.16 diff -u -p -r1.16 inherit.exp --- gdb/testsuite/gdb.cp/inherit.exp 26 Mar 2010 18:05:46 -0000 1.16 +++ gdb/testsuite/gdb.cp/inherit.exp 6 Apr 2010 12:40:45 -0000 @@ -502,7 +502,7 @@ proc test_print_anon_union {} { set name "print type of anonymous union" set re_tag "class_with_anon_union" - set re_class "(class $re_tag \{${ws}public:|struct $re_tag\{)" + set re_class "(class $re_tag \{${ws}public:|struct $re_tag \{)" set re_fields "int one;${ws}union \{${ws}int a;${ws}long( int)? b;${ws}\};" gdb_test_multiple "ptype g_anon_union" $name { -re "type = $re_class${ws}$re_fields$nl\}$nl$gdb_prompt $" { -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com