Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: sami wagiaalla <swagiaal@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] Test and support all cpp operator types
Date: Fri, 04 Jun 2010 20:55:00 -0000	[thread overview]
Message-ID: <m3k4qev7pe.fsf@fleche.redhat.com> (raw)
In-Reply-To: <4BF2F4F6.8080303@redhat.com> (sami wagiaalla's message of "Tue,	18 May 2010 16:13:42 -0400")

>>>>> "Sami" == sami wagiaalla <swagiaal@redhat.com> writes:

Sami> It is weird but it is due to the nature of the symbol tables. The
Sami> first iteration, by make_symbol_overload_list_using, is iteration over
Sami> the blocks' import statements. The Second iteration is actually
Sami> searching for the symbol.

Sami> If we assume that names belonging to namespaces can only be in the
Sami> static scope -since namespace symbols are flattened to the nearest
Sami> parent- then we can separate the qualified and unqualified searches
Sami> and eliminate the nesting of the iterations.

Sami> Please see patch 2/2.

Thanks.

Sami>     2010-05-18  Sami Wagiaalla  <swagiaal@redhat.com>
Sami>     	* value.h: Created oload_search_type enum.
Sami>     	(find_overload_match): Use oload_search_type enum.
Sami>     	* valops.c (find_overload_match): Support combined member and
Sami>     	non-member search.
Sami>     	* eval.c (evaluate_subexp_standard): Calls to
Sami>     	find_overload_match now use oload_search_type enum.
Sami>     	(oload_method_static): Verify index is a proper value.
Sami>     	* valarith.c (value_user_defined_cpp_op): Search for and handle
Sami>     	both member and non-member operators.
Sami>     	(value_user_defined_cpp_op): New function.
Sami>     	(value_user_defined_op): New function.
Sami>     	(value_x_unop): Use value_user_defined_op.
Sami>     	(value_x_binop): Ditto.
Sami>     	* cp-support.c (make_symbol_overload_list_using): Added block
Sami>     	iteration.
Sami>     	Add check for namespace aliases and imported declarations.
>     2010-05-18  Sami Wagiaalla  <swagiaal@redhat.com>
Sami>     	* gdb.cp/koenig.exp: Test for ADL operators.
Sami>     	* gdb.cp/koenig.cc: Added ADL operators.
Sami>     	* gdb.cp/operator.exp: New test.
Sami>     	* gdb.cp/operator.cc: New test.

This is ok.  Thanks again.

Tom


  reply	other threads:[~2010-06-04 20:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-11 20:38 [PATCH] " sami wagiaalla
2010-05-13  0:00 ` Tom Tromey
2010-05-18 20:49   ` [PATCH 1/2] " sami wagiaalla
2010-06-04 20:55     ` Tom Tromey [this message]
2010-05-18 22:31   ` [PATCH 2/2] " sami wagiaalla
2010-06-04 20:59     ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3k4qev7pe.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=swagiaal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox