From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20490 invoked by alias); 4 Jun 2010 20:55:33 -0000 Received: (qmail 20481 invoked by uid 22791); 4 Jun 2010 20:55:32 -0000 X-SWARE-Spam-Status: No, hits=-5.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 04 Jun 2010 20:55:28 +0000 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o54KtRZl006249 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 4 Jun 2010 16:55:27 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o54KtQtL030312; Fri, 4 Jun 2010 16:55:26 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o54KtP2x000978; Fri, 4 Jun 2010 16:55:25 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 698C537897F; Fri, 4 Jun 2010 14:55:25 -0600 (MDT) From: Tom Tromey To: sami wagiaalla Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/2] Test and support all cpp operator types References: <4BE9BE28.6080800@redhat.com> <4BF2F4F6.8080303@redhat.com> Reply-To: tromey@redhat.com Date: Fri, 04 Jun 2010 20:55:00 -0000 In-Reply-To: <4BF2F4F6.8080303@redhat.com> (sami wagiaalla's message of "Tue, 18 May 2010 16:13:42 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-06/txt/msg00135.txt.bz2 >>>>> "Sami" == sami wagiaalla writes: Sami> It is weird but it is due to the nature of the symbol tables. The Sami> first iteration, by make_symbol_overload_list_using, is iteration over Sami> the blocks' import statements. The Second iteration is actually Sami> searching for the symbol. Sami> If we assume that names belonging to namespaces can only be in the Sami> static scope -since namespace symbols are flattened to the nearest Sami> parent- then we can separate the qualified and unqualified searches Sami> and eliminate the nesting of the iterations. Sami> Please see patch 2/2. Thanks. Sami> 2010-05-18 Sami Wagiaalla Sami> * value.h: Created oload_search_type enum. Sami> (find_overload_match): Use oload_search_type enum. Sami> * valops.c (find_overload_match): Support combined member and Sami> non-member search. Sami> * eval.c (evaluate_subexp_standard): Calls to Sami> find_overload_match now use oload_search_type enum. Sami> (oload_method_static): Verify index is a proper value. Sami> * valarith.c (value_user_defined_cpp_op): Search for and handle Sami> both member and non-member operators. Sami> (value_user_defined_cpp_op): New function. Sami> (value_user_defined_op): New function. Sami> (value_x_unop): Use value_user_defined_op. Sami> (value_x_binop): Ditto. Sami> * cp-support.c (make_symbol_overload_list_using): Added block Sami> iteration. Sami> Add check for namespace aliases and imported declarations. > 2010-05-18 Sami Wagiaalla Sami> * gdb.cp/koenig.exp: Test for ADL operators. Sami> * gdb.cp/koenig.cc: Added ADL operators. Sami> * gdb.cp/operator.exp: New test. Sami> * gdb.cp/operator.cc: New test. This is ok. Thanks again. Tom