From: Tom Tromey <tromey@redhat.com>
To: sami wagiaalla <swagiaal@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] Test and support all cpp operator types
Date: Fri, 04 Jun 2010 20:59:00 -0000 [thread overview]
Message-ID: <m3fx12v7i9.fsf@fleche.redhat.com> (raw)
In-Reply-To: <4BF2FAF3.5010005@redhat.com> (sami wagiaalla's message of "Tue, 18 May 2010 16:39:15 -0400")
>>>>> "Sami" == sami wagiaalla <swagiaal@redhat.com> writes:
Sami> This patch fixes the above. It assumes that namespace names will
Sami> belong to the static and global blocks. This enables us to separate
Sami> the non-namespace iterative search from the namespace search.
Great, thanks.
One nit.
Sami> + /* look in the static block. */
Sami> + block = block_static_block (get_selected_block (0));
Sami> + make_symbol_overload_list_block (name, block);
Sami> + /* look in the global block. */
In both of these comments, the "L" in "look" should be capitalized.
Ok with this change. Thanks again.
Tom
prev parent reply other threads:[~2010-06-04 20:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-11 20:38 [PATCH] " sami wagiaalla
2010-05-13 0:00 ` Tom Tromey
2010-05-18 20:49 ` [PATCH 1/2] " sami wagiaalla
2010-06-04 20:55 ` Tom Tromey
2010-05-18 22:31 ` [PATCH 2/2] " sami wagiaalla
2010-06-04 20:59 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3fx12v7i9.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=swagiaal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox