From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23078 invoked by alias); 4 Jun 2010 20:59:49 -0000 Received: (qmail 23070 invoked by uid 22791); 4 Jun 2010 20:59:48 -0000 X-SWARE-Spam-Status: No, hits=-5.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 04 Jun 2010 20:59:44 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o54Kxh3e010602 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 4 Jun 2010 16:59:43 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o54KxhS2006019; Fri, 4 Jun 2010 16:59:43 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o54KxgXs001026; Fri, 4 Jun 2010 16:59:42 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 166A937897F; Fri, 4 Jun 2010 14:59:42 -0600 (MDT) From: Tom Tromey To: sami wagiaalla Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] Test and support all cpp operator types References: <4BE9BE28.6080800@redhat.com> <4BF2FAF3.5010005@redhat.com> Reply-To: tromey@redhat.com Date: Fri, 04 Jun 2010 20:59:00 -0000 In-Reply-To: <4BF2FAF3.5010005@redhat.com> (sami wagiaalla's message of "Tue, 18 May 2010 16:39:15 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-06/txt/msg00136.txt.bz2 >>>>> "Sami" == sami wagiaalla writes: Sami> This patch fixes the above. It assumes that namespace names will Sami> belong to the static and global blocks. This enables us to separate Sami> the non-namespace iterative search from the namespace search. Great, thanks. One nit. Sami> + /* look in the static block. */ Sami> + block = block_static_block (get_selected_block (0)); Sami> + make_symbol_overload_list_block (name, block); Sami> + /* look in the global block. */ In both of these comments, the "L" in "look" should be capitalized. Ok with this change. Thanks again. Tom