From: Tom Tromey <tromey@redhat.com>
To: Hui Zhu <teawater@gmail.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [PATCH] printcmd.c (ui_printf): make internalvar string can be printf and eval when inferior cannot alloc memory
Date: Fri, 19 Aug 2011 14:15:00 -0000 [thread overview]
Message-ID: <m3k4a9lc8i.fsf@fleche.redhat.com> (raw)
In-Reply-To: <CANFwon3kjh4HBH59BXyM=R451iAozjJjJ1kACg=Jbv607PV6aA@mail.gmail.com> (Hui Zhu's message of "Thu, 18 Aug 2011 10:53:07 +0800")
>>>>> ">" == Hui Zhu <teawater@gmail.com> writes:
Tom> This test seems odd to me. Why does the lvalue-ness of the value
Tom> matter?
>> I don't understand your means, could you do some explain?
I just don't understand why a check of the VALUE_LVAL is necessary.
Does something go wrong in the other cases? It doesn't seem to me that
it should.
Tom
next prev parent reply other threads:[~2011-08-19 14:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-20 10:37 Hui Zhu
2011-07-21 20:43 ` Tom Tromey
2011-08-14 15:10 ` Hui Zhu
2011-08-15 19:06 ` Tom Tromey
2011-08-16 4:58 ` Hui Zhu
2011-08-17 14:38 ` Tom Tromey
2011-08-18 2:54 ` Hui Zhu
2011-08-19 14:15 ` Tom Tromey [this message]
2011-09-06 8:50 ` Hui Zhu
2011-09-06 13:44 ` Jan Kratochvil
2011-09-07 9:27 ` Hui Zhu
2011-09-07 10:02 ` Jan Kratochvil
2011-09-09 7:59 ` Hui Zhu
2011-09-09 12:32 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3k4a9lc8i.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=teawater@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox