From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-83110-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 19683 invoked by alias); 19 Aug 2011 14:15:03 -0000
Received: (qmail 19551 invoked by uid 22791); 19 Aug 2011 14:15:01 -0000
X-SWARE-Spam-Status: No, hits=-7.5 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 19 Aug 2011 14:14:40 +0000
Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p7JEEd8I015697	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Fri, 19 Aug 2011 10:14:39 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p7JEEcHn024621;	Fri, 19 Aug 2011 10:14:38 -0400
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p7JEEbYB006753;	Fri, 19 Aug 2011 10:14:37 -0400
From: Tom Tromey <tromey@redhat.com>
To: Hui Zhu <teawater@gmail.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [PATCH] printcmd.c (ui_printf): make internalvar string can be printf and eval when inferior cannot alloc memory
References: <CANFwon0RttecHT1BrVx886NC6yCsojHm-MWfr7ttS8=CjoNEzg@mail.gmail.com>	<m339hz1i9v.fsf@fleche.redhat.com>	<CANFwon0wqsOirAz078-y+ti-WFNHGJ45F_-HfS89ViYM02UDFA@mail.gmail.com>	<m3fwl2ebq1.fsf@fleche.redhat.com>	<CANFwon1h3fytbmBB5DiXjLt=pa7nt_JTuFhuGDxbVjCS=7FwtQ@mail.gmail.com>	<m3k4acaysh.fsf@fleche.redhat.com>	<CANFwon3kjh4HBH59BXyM=R451iAozjJjJ1kACg=Jbv607PV6aA@mail.gmail.com>
Date: Fri, 19 Aug 2011 14:15:00 -0000
In-Reply-To: <CANFwon3kjh4HBH59BXyM=R451iAozjJjJ1kACg=Jbv607PV6aA@mail.gmail.com>	(Hui Zhu's message of "Thu, 18 Aug 2011 10:53:07 +0800")
Message-ID: <m3k4a9lc8i.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-08/txt/msg00370.txt.bz2

>>>>> ">" =3D=3D Hui Zhu <teawater@gmail.com> writes:

Tom> This test seems odd to me. =C2=A0Why does the lvalue-ness of the value
Tom> matter?

>> I don't understand your means, could you do some explain?

I just don't understand why a check of the VALUE_LVAL is necessary.
Does something go wrong in the other cases?  It doesn't seem to me that
it should.

Tom