From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Hui Zhu <teawater@gmail.com>
Cc: Tom Tromey <tromey@redhat.com>,
gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [PATCH] printcmd.c (ui_printf): make internalvar string can be printf and eval when inferior cannot alloc memory
Date: Wed, 07 Sep 2011 10:02:00 -0000 [thread overview]
Message-ID: <20110907095850.GA25473@host1.jankratochvil.net> (raw)
In-Reply-To: <CANFwon35OBYsAnbEPewqo9-ussYkGq8WDxPeTKnb0Cu=LWxUfA@mail.gmail.com>
On Wed, 07 Sep 2011 04:55:32 +0200, Hui Zhu wrote:
> +#Test printing internal var values with printf
> +proc test_printf_with_internalvar {} {
> + gdb_test "set \$a={\'a\',\'b\'}" ""
Escaping of ' is redundant.
> + gdb_test "printf \"%s\\n\", \$a" "ab"
I would find easier { and } instead of " and " to prevent so many backslashes
but opinions differ on it, FYI:
gdb_test_no_output {set $a={'a','b'}}
gdb_test {printf "%s\n", $a} "ab"
Still this testcase FAILs for me:
printf "%s\n", $a^M
abX^M
(gdb) FAIL: gdb.base/printcmds.exp: printf "%s\n", $a
Where X is some binary unprintable garbage character, not sure which way you
plan to fix it (maybe some `error' call if there is no zero-terminator?).
Thanks,
Jan
next prev parent reply other threads:[~2011-09-07 9:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-20 10:37 Hui Zhu
2011-07-21 20:43 ` Tom Tromey
2011-08-14 15:10 ` Hui Zhu
2011-08-15 19:06 ` Tom Tromey
2011-08-16 4:58 ` Hui Zhu
2011-08-17 14:38 ` Tom Tromey
2011-08-18 2:54 ` Hui Zhu
2011-08-19 14:15 ` Tom Tromey
2011-09-06 8:50 ` Hui Zhu
2011-09-06 13:44 ` Jan Kratochvil
2011-09-07 9:27 ` Hui Zhu
2011-09-07 10:02 ` Jan Kratochvil [this message]
2011-09-09 7:59 ` Hui Zhu
2011-09-09 12:32 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110907095850.GA25473@host1.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=teawater@gmail.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox