From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-83530-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 29524 invoked by alias); 7 Sep 2011 09:59:15 -0000
Received: (qmail 29514 invoked by uid 22791); 7 Sep 2011 09:59:14 -0000
X-SWARE-Spam-Status: No, hits=-6.8 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 07 Sep 2011 09:58:56 +0000
Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p879wtUq015407	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Wed, 7 Sep 2011 05:58:55 -0400
Received: from host1.jankratochvil.net (ovpn-116-38.ams2.redhat.com [10.36.116.38])	by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p879wqsI000907	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);	Wed, 7 Sep 2011 05:58:55 -0400
Received: from host1.jankratochvil.net (localhost [127.0.0.1])	by host1.jankratochvil.net (8.14.4/8.14.4) with ESMTP id p879wp7H027505;	Wed, 7 Sep 2011 11:58:51 +0200
Received: (from jkratoch@localhost)	by host1.jankratochvil.net (8.14.4/8.14.4/Submit) id p879wovc027498;	Wed, 7 Sep 2011 11:58:50 +0200
Date: Wed, 07 Sep 2011 10:02:00 -0000
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Hui Zhu <teawater@gmail.com>
Cc: Tom Tromey <tromey@redhat.com>,        gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [PATCH] printcmd.c (ui_printf): make internalvar string can be printf and eval when inferior cannot alloc memory
Message-ID: <20110907095850.GA25473@host1.jankratochvil.net>
References: <m339hz1i9v.fsf@fleche.redhat.com> <CANFwon0wqsOirAz078-y+ti-WFNHGJ45F_-HfS89ViYM02UDFA@mail.gmail.com> <m3fwl2ebq1.fsf@fleche.redhat.com> <CANFwon1h3fytbmBB5DiXjLt=pa7nt_JTuFhuGDxbVjCS=7FwtQ@mail.gmail.com> <m3k4acaysh.fsf@fleche.redhat.com> <CANFwon3kjh4HBH59BXyM=R451iAozjJjJ1kACg=Jbv607PV6aA@mail.gmail.com> <m3k4a9lc8i.fsf@fleche.redhat.com> <CANFwon0=Trk5i-j4MRPOAXx0AeJaqsZk6Tg052n9_EUEiQ=LrQ@mail.gmail.com> <20110906085007.GA19880@host1.jankratochvil.net> <CANFwon35OBYsAnbEPewqo9-ussYkGq8WDxPeTKnb0Cu=LWxUfA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CANFwon35OBYsAnbEPewqo9-ussYkGq8WDxPeTKnb0Cu=LWxUfA@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-09/txt/msg00110.txt.bz2

On Wed, 07 Sep 2011 04:55:32 +0200, Hui Zhu wrote:
> +#Test printing internal var values with printf
> +proc test_printf_with_internalvar {} {
> +    gdb_test "set \$a={\'a\',\'b\'}" ""

Escaping of ' is redundant.

> +    gdb_test "printf \"%s\\n\", \$a" "ab"

I would find easier { and } instead of " and " to prevent so many backslashes
but opinions differ on it, FYI:
    gdb_test_no_output {set $a={'a','b'}}
    gdb_test {printf "%s\n", $a} "ab"


Still this testcase FAILs for me:
printf "%s\n", $a^M
abX^M
(gdb) FAIL: gdb.base/printcmds.exp: printf "%s\n", $a

Where X is some binary unprintable garbage character, not sure which way you
plan to fix it (maybe some `error' call if there is no zero-terminator?).


Thanks,
Jan