Re: [patch 2/2] Perform a namespace lookup at every block level

[Tom Tromey <tromey@redhat.com>]

>>>>> "Sami" == Sami Wagiaalla <swagiaal@redhat.com> writes:

Sami> +  return cp_lookup_symbol_namespace(scope, name, linkage_name, block, domain, 1);

Missing space before "(".  There are a few of these.

Sami> +                                     search_parents );

Extra space.

Sami> +      directive_match = search_parents ?
Sami> +                        strncmp (scope, current->import_dest,
Sami> +                                 strlen(current->import_dest)) == 0 :
Sami> +                        strcmp (scope, current->import_dest) == 0;

GNU style is to line break before an operator, not after.
There are several instances of this.

Sami> +############################################
Sami> +# Test that the search can fail efficiently
Sami> +
Sami> +gdb_test "print y" "No symbol \"y\" in current context."

I like the test case :)

Sami> -				    VAR_DOMAIN);
Sami> +				    VAR_DOMAIN,1);

Missing space after the ",".

Tom