From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-67662-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 27164 invoked by alias); 13 Oct 2009 20:22:42 -0000
Received: (qmail 27151 invoked by uid 22791); 13 Oct 2009 20:22:41 -0000
X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 	tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 13 Oct 2009 20:22:36 +0000
Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) 	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n9DKMZH8017006 	for <gdb-patches@sourceware.org>; Tue, 13 Oct 2009 16:22:35 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) 	by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id n9DKMY8J030719; 	Tue, 13 Oct 2009 16:22:35 -0400
Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) 	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n9DKMXOR009894; 	Tue, 13 Oct 2009 16:22:34 -0400
Received: by opsy.redhat.com (Postfix, from userid 500) 	id 296A3378188; Tue, 13 Oct 2009 14:22:33 -0600 (MDT)
From: Tom Tromey <tromey@redhat.com>
To: Sami Wagiaalla <swagiaal@redhat.com>
Cc: GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [patch 2/2] Perform a namespace lookup at every block level
References: <4A57512A.7090208@redhat.com> 	<20090710194949.GA2064@caradoc.them.org> <4A5B68A4.30006@redhat.com> 	<4A68B91D.2080206@redhat.com> <4A8B0FD9.7010603@redhat.com> 	<4AA14648.7090600@redhat.com>
Reply-To: tromey@redhat.com
Date: Tue, 13 Oct 2009 20:22:00 -0000
In-Reply-To: <4AA14648.7090600@redhat.com> (Sami Wagiaalla's message of "Fri, 	04 Sep 2009 12:54:32 -0400")
Message-ID: <m3iqejjb7a.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-10/txt/msg00285.txt.bz2

>>>>> "Sami" == Sami Wagiaalla <swagiaal@redhat.com> writes:

Sami> +  return cp_lookup_symbol_namespace(scope, name, linkage_name, block, domain, 1);

Missing space before "(".  There are a few of these.

Sami> +                                     search_parents );

Extra space.

Sami> +      directive_match = search_parents ?
Sami> +                        strncmp (scope, current->import_dest,
Sami> +                                 strlen(current->import_dest)) == 0 :
Sami> +                        strcmp (scope, current->import_dest) == 0;

GNU style is to line break before an operator, not after.
There are several instances of this.

Sami> +############################################
Sami> +# Test that the search can fail efficiently
Sami> +
Sami> +gdb_test "print y" "No symbol \"y\" in current context."

I like the test case :)

Sami> -				    VAR_DOMAIN);
Sami> +				    VAR_DOMAIN,1);

Missing space after the ",".

Tom