Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Sami Wagiaalla <swagiaal@redhat.com>
Cc: GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [patch] Perform a namespace lookup at every block level
Date: Fri, 10 Jul 2009 20:16:00 -0000	[thread overview]
Message-ID: <20090710194949.GA2064@caradoc.them.org> (raw)
In-Reply-To: <4A57512A.7090208@redhat.com>

On Fri, Jul 10, 2009 at 10:33:14AM -0400, Sami Wagiaalla wrote:
> Now that import information is stored in the nearest block,
> this patch changes things so that a namespace lookup is correctly
> performed at every block level.

Where in the overall search order are block-level using directives
supposed to fall according to the standard?  And where does this patch
put them?

It looks to me like this change causes the global scope to be searched
too early (and too often).  Given this:

int a;
int foo()
{
  int a;
  if (...)
    {
       breakpoint_here;
    }
}

If we do a namespace scope search for a in the inner block, we'll find
the copy in this file instead of the enclosing local.

-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2009-07-10 19:50 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-10 15:10 Sami Wagiaalla
2009-07-10 20:16 ` Daniel Jacobowitz [this message]
2009-07-13 17:55   ` Sami Wagiaalla
2009-07-23 19:46     ` Sami Wagiaalla
2009-07-23 22:19       ` Sami Wagiaalla
2009-07-29 22:12       ` Tom Tromey
2009-08-18 20:34       ` [patch 1/2] " Sami Wagiaalla
2009-10-13 19:47         ` Tom Tromey
2009-10-20 20:50           ` Sami Wagiaalla
2009-11-10 22:23             ` Tom Tromey
2009-11-10 22:26               ` Tom Tromey
2009-11-16 15:32                 ` Sami Wagiaalla
2009-11-16 19:16                   ` Sami Wagiaalla
2009-11-24 19:06                   ` Sami Wagiaalla
2009-12-21 21:44                     ` Tom Tromey
2009-08-18 20:46       ` [patch 2/2] " Sami Wagiaalla
2009-09-04 16:57         ` Sami Wagiaalla
2009-10-13 20:22           ` Tom Tromey
2009-10-22 17:47             ` Sami Wagiaalla
2009-11-10 22:52               ` Tom Tromey
2009-11-16 17:55                 ` Sami Wagiaalla
2009-11-24 19:12                   ` Sami Wagiaalla
2009-12-21 21:55                     ` Tom Tromey
2010-01-11 21:24                       ` Sami Wagiaalla
2010-01-12 17:43                         ` Tom Tromey
2010-01-14 16:47                           ` Sami Wagiaalla
2010-01-14 20:18                             ` Sami Wagiaalla
2010-01-15 18:06                               ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090710194949.GA2064@caradoc.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    --cc=swagiaal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox