From: Tom Tromey <tromey@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Jan Kratochvil <jan.kratochvil@redhat.com>,
gdb-patches@sourceware.org, gdb@sourceware.org,
Vladimir Prus <vladimir@codesourcery.com>
Subject: Re: [patch] Re: Regression: field type preservation: 7.0 -> 7.0.1+HEAD
Date: Tue, 05 Jan 2010 17:49:00 -0000 [thread overview]
Message-ID: <m3iqbga1ey.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20100103045717.GZ2788@adacore.com> (Joel Brobecker's message of "Sun, 3 Jan 2010 08:57:17 +0400")
>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:
Joel> In my opinion, I agree with Daniel's comment that it is unusual to
Joel> call check_typedef without storing the function result.
FWIW, we do have a few of these. We should at least comment that this
is called for side effects where this is done, I've tried to do that
with new calls.
Joel> So, my proposal, if the other maintainers agree, is to document
Joel> the side-effect of check_typedef (sets the typedef TYPE_LENGTH)
Joel> as this appears to be a fully-intended behavior, and then do:
This is documented by the TYPE_LENGTH macro, which is how I knew about
it :-). This comment also mentions that allocate_value calls
check_typedef.
Tom
prev parent reply other threads:[~2010-01-05 17:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100101184505.GA18391@host0.dyn.jankratochvil.net>
[not found] ` <201001021308.19130.vladimir@codesourcery.com>
2010-01-02 20:30 ` Jan Kratochvil
2010-01-03 4:58 ` Joel Brobecker
2010-01-03 5:48 ` Jan Kratochvil
2010-01-03 6:03 ` Joel Brobecker
2010-01-03 17:06 ` Daniel Jacobowitz
2010-01-03 19:26 ` Jan Kratochvil
2010-01-03 21:52 ` Daniel Jacobowitz
2010-01-03 22:14 ` Jan Kratochvil
2010-01-05 17:49 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3iqbga1ey.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=gdb@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=vladimir@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox