Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org, gdb@sourceware.org,
		Vladimir Prus <vladimir@codesourcery.com>
Subject: Re: [patch] Re: Regression: field type preservation: 7.0 ->  7.0.1+HEAD
Date: Sun, 03 Jan 2010 06:03:00 -0000	[thread overview]
Message-ID: <20100103060305.GB2788@adacore.com> (raw)
In-Reply-To: <20100103054727.GA31207@host0.dyn.jankratochvil.net>

> gdb/
> 2010-01-03  Jan Kratochvil  <jan.kratochvil@redhat.com>
> 	    Joel Brobecker  <brobecker@adacore.com>
> 
> 	* gdbtypes.c (check_typedef): New comment on type length.
> 	* value.c (allocate_value_lazy): Remove the unused atype variable.  New
> 	comment on type length.
> 	(value_primitive_field): Keep the original TYPE value, new comment.
> 
> gdb/testsuite/
> 2010-01-03  Jan Kratochvil  <jan.kratochvil@redhat.com>
> 
> 	* gdb.mi/var-cmd.c (do_bitfield_tests): Change "V.sharable" type to
> 	"uint_for_mi_testing".

That would be fine with me - thanks for doing that. Confirmation from
DanielJ would be nice, though, since he raised concerns about it.
Hopefully all the comments we added will address them.

-- 
Joel


  reply	other threads:[~2010-01-03  6:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20100101184505.GA18391@host0.dyn.jankratochvil.net>
     [not found] ` <201001021308.19130.vladimir@codesourcery.com>
2010-01-02 20:30   ` Jan Kratochvil
2010-01-03  4:58     ` Joel Brobecker
2010-01-03  5:48       ` Jan Kratochvil
2010-01-03  6:03         ` Joel Brobecker [this message]
2010-01-03 17:06           ` Daniel Jacobowitz
2010-01-03 19:26             ` Jan Kratochvil
2010-01-03 21:52               ` Daniel Jacobowitz
2010-01-03 22:14                 ` Jan Kratochvil
2010-01-05 17:49       ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100103060305.GB2788@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=gdb@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    --cc=vladimir@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox