From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8484 invoked by alias); 3 Jan 2010 06:03:46 -0000 Received: (qmail 8314 invoked by uid 22791); 3 Jan 2010 06:03:45 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 03 Jan 2010 06:03:41 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 8A60B2BAB69; Sun, 3 Jan 2010 01:03:39 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id uYi42kim6F33; Sun, 3 Jan 2010 01:03:39 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id C08282BAB8E; Sun, 3 Jan 2010 01:03:38 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 0DEB4F5937; Sun, 3 Jan 2010 07:03:05 +0100 (CET) Date: Sun, 03 Jan 2010 06:03:00 -0000 From: Joel Brobecker To: Jan Kratochvil Cc: gdb-patches@sourceware.org, gdb@sourceware.org, Vladimir Prus Subject: Re: [patch] Re: Regression: field type preservation: 7.0 -> 7.0.1+HEAD Message-ID: <20100103060305.GB2788@adacore.com> References: <20100101184505.GA18391@host0.dyn.jankratochvil.net> <201001021308.19130.vladimir@codesourcery.com> <20100102203022.GA8372@host0.dyn.jankratochvil.net> <20100103045717.GZ2788@adacore.com> <20100103054727.GA31207@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100103054727.GA31207@host0.dyn.jankratochvil.net> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-01/txt/msg00038.txt.bz2 > gdb/ > 2010-01-03 Jan Kratochvil > Joel Brobecker > > * gdbtypes.c (check_typedef): New comment on type length. > * value.c (allocate_value_lazy): Remove the unused atype variable. New > comment on type length. > (value_primitive_field): Keep the original TYPE value, new comment. > > gdb/testsuite/ > 2010-01-03 Jan Kratochvil > > * gdb.mi/var-cmd.c (do_bitfield_tests): Change "V.sharable" type to > "uint_for_mi_testing". That would be fine with me - thanks for doing that. Confirmation from DanielJ would be nice, though, since he raised concerns about it. Hopefully all the comments we added will address them. -- Joel