From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8543 invoked by alias); 5 Jan 2010 17:49:03 -0000 Received: (qmail 8528 invoked by uid 22791); 5 Jan 2010 17:49:02 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 05 Jan 2010 17:48:59 +0000 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o05Hm8aj011442 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 5 Jan 2010 12:48:08 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o05Hm7X6011569; Tue, 5 Jan 2010 12:48:07 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o05Hm6EQ000426; Tue, 5 Jan 2010 12:48:06 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id C267C3781CA; Tue, 5 Jan 2010 10:48:05 -0700 (MST) From: Tom Tromey To: Joel Brobecker Cc: Jan Kratochvil , gdb-patches@sourceware.org, gdb@sourceware.org, Vladimir Prus Subject: Re: [patch] Re: Regression: field type preservation: 7.0 -> 7.0.1+HEAD References: <20100101184505.GA18391@host0.dyn.jankratochvil.net> <201001021308.19130.vladimir@codesourcery.com> <20100102203022.GA8372@host0.dyn.jankratochvil.net> <20100103045717.GZ2788@adacore.com> Reply-To: tromey@redhat.com Date: Tue, 05 Jan 2010 17:49:00 -0000 In-Reply-To: <20100103045717.GZ2788@adacore.com> (Joel Brobecker's message of "Sun, 3 Jan 2010 08:57:17 +0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-01/txt/msg00085.txt.bz2 >>>>> "Joel" == Joel Brobecker writes: Joel> In my opinion, I agree with Daniel's comment that it is unusual to Joel> call check_typedef without storing the function result. FWIW, we do have a few of these. We should at least comment that this is called for side effects where this is done, I've tried to do that with new calls. Joel> So, my proposal, if the other maintainers agree, is to document Joel> the side-effect of check_typedef (sets the typedef TYPE_LENGTH) Joel> as this appears to be a fully-intended behavior, and then do: This is documented by the TYPE_LENGTH macro, which is how I knew about it :-). This comment also mentions that allocate_value calls check_typedef. Tom