varobj bug?

varobj bug?

[Pedro Alves]

[ Just stumbled on this while reading this code. ]

Isn't the patch below a bug fix?  FI possibly points at
the frame returned by:

 fi = find_frame_addr_in_frame_chain (frame);

not the originally selected frame.

Maybe this code should be using make_cleanup_restore_current_thread?

-- 
Pedro Alves

---
 gdb/varobj.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: src/gdb/varobj.c
===================================================================
--- src.orig/gdb/varobj.c	2009-06-08 00:37:55.000000000 +0100
+++ src/gdb/varobj.c	2009-06-08 00:38:47.000000000 +0100
@@ -577,7 +577,7 @@ varobj_create (char *objname,
       var->root->rootvar = var;
 
       /* Reset the selected frame */
-      if (fi != NULL)
+      if (old_fi != NULL)
 	select_frame (old_fi);
     }
 

Re: varobj bug?

[Tom Tromey]

>>>>> "Pedro" == Pedro Alves <pedro@codesourcery.com> writes:

Pedro> [ Just stumbled on this while reading this code. ]
Pedro> Isn't the patch below a bug fix?  FI possibly points at
Pedro> the frame returned by:
Pedro>  fi = find_frame_addr_in_frame_chain (frame);
Pedro> not the originally selected frame.

I agree with your analysis.

Pedro> Maybe this code should be using make_cleanup_restore_current_thread?

This also sounds reasonable.

Tom

Re: varobj bug?

[Pedro Alves]

On Tuesday 09 June 2009 22:09:14, Tom Tromey wrote:
> >>>>> "Pedro" == Pedro Alves <pedro@codesourcery.com> writes:
> 
> Pedro> [ Just stumbled on this while reading this code. ]
> Pedro> Isn't the patch below a bug fix?  FI possibly points at
> Pedro> the frame returned by:
> Pedro>  fi = find_frame_addr_in_frame_chain (frame);
> Pedro> not the originally selected frame.
> 
> I agree with your analysis.

Thanks.  I tested and checked in the fixlet with this
changelog entry:

2009-06-11  Pedro Alves  <pedro@codesourcery.com>

	* varobj.c (varobj_create): Properly restore the selected frame.

> Pedro> Maybe this code should be using make_cleanup_restore_current_thread?
> 
> This also sounds reasonable.

Ok, I'll see about cooking something up.

-- 
Pedro Alves