From: Pedro Alves <pedro@codesourcery.com>
To: tromey@redhat.com
Cc: gdb-patches@sourceware.org
Subject: Re: varobj bug?
Date: Wed, 10 Jun 2009 23:41:00 -0000 [thread overview]
Message-ID: <200906110042.11900.pedro@codesourcery.com> (raw)
In-Reply-To: <m3hbypi079.fsf@fleche.redhat.com>
On Tuesday 09 June 2009 22:09:14, Tom Tromey wrote:
> >>>>> "Pedro" == Pedro Alves <pedro@codesourcery.com> writes:
>
> Pedro> [ Just stumbled on this while reading this code. ]
> Pedro> Isn't the patch below a bug fix? FI possibly points at
> Pedro> the frame returned by:
> Pedro> fi = find_frame_addr_in_frame_chain (frame);
> Pedro> not the originally selected frame.
>
> I agree with your analysis.
Thanks. I tested and checked in the fixlet with this
changelog entry:
2009-06-11 Pedro Alves <pedro@codesourcery.com>
* varobj.c (varobj_create): Properly restore the selected frame.
> Pedro> Maybe this code should be using make_cleanup_restore_current_thread?
>
> This also sounds reasonable.
Ok, I'll see about cooking something up.
--
Pedro Alves
prev parent reply other threads:[~2009-06-10 23:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-07 23:40 Pedro Alves
2009-06-09 21:11 ` Tom Tromey
2009-06-10 23:41 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906110042.11900.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox