Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Michael Snyder <msnyder@vmware.com>
Cc: Jakob Engblom <jakob@virtutech.com>,
	        "gdb-patches\@sourceware.org"
	<gdb-patches@sourceware.org>
Subject: Re: GDB MI Reverse Commands added [1 of 3]
Date: Mon, 31 Aug 2009 20:29:00 -0000	[thread overview]
Message-ID: <m3hbvn21mx.fsf@fleche.redhat.com> (raw)
In-Reply-To: <4A95E670.9040402@vmware.com> (Michael Snyder's message of "Wed, 	26 Aug 2009 18:50:40 -0700")

Michael> Group, this patch seemed to have gotten a little munged in
Michael> email.  I've taken the liberty of re-diffing it, to restore
Michael> white space context.

Thanks.

I have a few nits to pick.

Jakob> +  if (argc > 0 && strcmp(argv[0], "--reverse") == 0)

Space before (".
There are a number of these.

Jakob> +/* continue in reverse direction:
Jakob> +   XXX: code duplicated from reverse.c */

We're trying not to add new FIXME-type comments.

In this particular case I think it is ok to just drop the comment.
However, if you prefer, I think you could add a new exported
"make_cleanup_..." function in reverse.c.

Tom


  parent reply	other threads:[~2009-08-31 20:02 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-26 14:38 Jakob Engblom
2009-08-27  1:13 ` Michael Snyder
2009-08-31 13:26   ` Jakob Engblom
2009-08-31 19:56     ` Michael Snyder
2009-09-01  6:37       ` Jakob Engblom
2009-09-01 19:08         ` Michael Snyder
2009-08-27  2:06 ` Michael Snyder
2009-08-31 13:15   ` Jakob Engblom
2009-08-31 20:29   ` Tom Tromey [this message]
2009-09-02  8:16   ` Vladimir Prus
2009-09-10 21:09     ` Michael Snyder
2009-09-10 21:10       ` Michael Snyder
2010-01-13 20:32     ` Jakob Engblom
2010-01-13 20:36       ` Vladimir Prus
2010-01-13 20:44         ` Michael Snyder
2009-12-15 19:39   ` Michael Snyder
2009-12-16  7:54     ` Vladimir Prus
2009-12-16  7:57       ` Vladimir Prus
2009-12-17 14:40         ` Jakob Engblom
2009-12-21 10:06           ` Vladimir Prus
2009-12-22 11:34             ` Jakob Engblom
2009-12-22 11:48               ` Vladimir Prus
2010-01-13 13:15                 ` Jakob Engblom
2009-12-22 18:22               ` Michael Snyder
2010-01-13 13:16                 ` Jakob Engblom
2010-02-12 21:33                 ` Michael Snyder
2009-08-27  3:11 ` Hui Zhu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3hbvn21mx.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jakob@virtutech.com \
    --cc=msnyder@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox