Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Vladimir Prus <vladimir@codesourcery.com>
To: "Jakob Engblom" <jakob@virtutech.com>
Cc: "'Michael Snyder'" <msnyder@vmware.com>,
	 gdb-patches@sourceware.org,  "'Hui Zhu'" <teawater@gmail.com>
Subject: Re: GDB MI Reverse Commands added [1 of 3]
Date: Tue, 22 Dec 2009 11:48:00 -0000	[thread overview]
Message-ID: <200912221448.20020.vladimir@codesourcery.com> (raw)
In-Reply-To: <00af01ca82fa$a8b74b60$fa25e220$@com>

On Tuesday 22 December 2009 14:34:00 Jakob Engblom wrote:

> > > Can someone familiar with the main reverse code illuminate me on how to call
> > into the reverse code in teh right way?  It seems that the reverse.c code has
> > already changed from the code that was (bad style) copied into mi-main.c...
> > which is exactly what we want to avoid in the first place.
> > >
> > > Or is the logical thing to do from MI to just call
> > >
> > > static void
> > > reverse_continue (char *args, int from_tty)
> > > {
> > >   exec_reverse_once ("continue", args, from_tty);
> > > }
> > >
> > > As the implementation of reverse continue?  This does looks like the we
> > submitted has rotted since the patch was submitted...
> > 
> > Just to clarify -- who's got the ball here? Calling 'reverse_continue' sounds
> > like reasonable thing to me
> > if one wants to do a reverse continue ;-)
> 
> I think the ball is mine. 
> 
> But I need to understand how to put the two things together, and for that I need
> some help by the people who did reverse.c. 
> 
> In particular, from MI, what should the "from_tty" argument be? And the "args"?
> MI args look different from the command-line arguments to me, so how can one
> convert between the two?

The from_tty should be 0. 'args' are probably not used for continue anyway,
and surely are not used for MI -exec-continue, so can be NULL.

Hope this helps.

- Volodya


  reply	other threads:[~2009-12-22 11:48 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-26 14:38 Jakob Engblom
2009-08-27  1:13 ` Michael Snyder
2009-08-31 13:26   ` Jakob Engblom
2009-08-31 19:56     ` Michael Snyder
2009-09-01  6:37       ` Jakob Engblom
2009-09-01 19:08         ` Michael Snyder
2009-08-27  2:06 ` Michael Snyder
2009-08-31 13:15   ` Jakob Engblom
2009-08-31 20:29   ` Tom Tromey
2009-09-02  8:16   ` Vladimir Prus
2009-09-10 21:09     ` Michael Snyder
2009-09-10 21:10       ` Michael Snyder
2010-01-13 20:32     ` Jakob Engblom
2010-01-13 20:36       ` Vladimir Prus
2010-01-13 20:44         ` Michael Snyder
2009-12-15 19:39   ` Michael Snyder
2009-12-16  7:54     ` Vladimir Prus
2009-12-16  7:57       ` Vladimir Prus
2009-12-17 14:40         ` Jakob Engblom
2009-12-21 10:06           ` Vladimir Prus
2009-12-22 11:34             ` Jakob Engblom
2009-12-22 11:48               ` Vladimir Prus [this message]
2010-01-13 13:15                 ` Jakob Engblom
2009-12-22 18:22               ` Michael Snyder
2010-01-13 13:16                 ` Jakob Engblom
2010-02-12 21:33                 ` Michael Snyder
2009-08-27  3:11 ` Hui Zhu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200912221448.20020.vladimir@codesourcery.com \
    --to=vladimir@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jakob@virtutech.com \
    --cc=msnyder@vmware.com \
    --cc=teawater@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox