From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14449 invoked by alias); 22 Dec 2009 11:48:28 -0000 Received: (qmail 14441 invoked by uid 22791); 22 Dec 2009 11:48:27 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 22 Dec 2009 11:48:23 +0000 Received: (qmail 19947 invoked from network); 22 Dec 2009 11:48:22 -0000 Received: from unknown (HELO wind.localnet) (vladimir@127.0.0.2) by mail.codesourcery.com with ESMTPA; 22 Dec 2009 11:48:22 -0000 From: Vladimir Prus To: "Jakob Engblom" Subject: Re: GDB MI Reverse Commands added [1 of 3] Date: Tue, 22 Dec 2009 11:48:00 -0000 User-Agent: KMail/1.12.2 (Linux/2.6.31-14-generic-pae; KDE/4.3.2; i686; ; ) Cc: "'Michael Snyder'" , gdb-patches@sourceware.org, "'Hui Zhu'" References: <00ce01ca265a$ccb66ca0$662345e0$@com> <200912211305.55412.vladimir@codesourcery.com> <00af01ca82fa$a8b74b60$fa25e220$@com> In-Reply-To: <00af01ca82fa$a8b74b60$fa25e220$@com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Message-Id: <200912221448.20020.vladimir@codesourcery.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-12/txt/msg00336.txt.bz2 On Tuesday 22 December 2009 14:34:00 Jakob Engblom wrote: > > > Can someone familiar with the main reverse code illuminate me on how to call > > into the reverse code in teh right way? It seems that the reverse.c code has > > already changed from the code that was (bad style) copied into mi-main.c... > > which is exactly what we want to avoid in the first place. > > > > > > Or is the logical thing to do from MI to just call > > > > > > static void > > > reverse_continue (char *args, int from_tty) > > > { > > > exec_reverse_once ("continue", args, from_tty); > > > } > > > > > > As the implementation of reverse continue? This does looks like the we > > submitted has rotted since the patch was submitted... > > > > Just to clarify -- who's got the ball here? Calling 'reverse_continue' sounds > > like reasonable thing to me > > if one wants to do a reverse continue ;-) > > I think the ball is mine. > > But I need to understand how to put the two things together, and for that I need > some help by the people who did reverse.c. > > In particular, from MI, what should the "from_tty" argument be? And the "args"? > MI args look different from the command-line arguments to me, so how can one > convert between the two? The from_tty should be 0. 'args' are probably not used for continue anyway, and surely are not used for MI -exec-continue, so can be NULL. Hope this helps. - Volodya