From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22489 invoked by alias); 31 Aug 2009 20:02:11 -0000 Received: (qmail 22390 invoked by uid 22791); 31 Aug 2009 20:02:10 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 31 Aug 2009 20:02:03 +0000 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n7VK20K2018276; Mon, 31 Aug 2009 16:02:00 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id n7VK207o004444; Mon, 31 Aug 2009 16:02:00 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n7VK1wX6022733; Mon, 31 Aug 2009 16:01:59 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 31FEF3781AF; Mon, 31 Aug 2009 14:01:58 -0600 (MDT) From: Tom Tromey To: Michael Snyder Cc: Jakob Engblom , "gdb-patches\@sourceware.org" Subject: Re: GDB MI Reverse Commands added [1 of 3] References: <00ce01ca265a$ccb66ca0$662345e0$@com> <4A95E670.9040402@vmware.com> Reply-To: tromey@redhat.com Date: Mon, 31 Aug 2009 20:29:00 -0000 In-Reply-To: <4A95E670.9040402@vmware.com> (Michael Snyder's message of "Wed, 26 Aug 2009 18:50:40 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-08/txt/msg00592.txt.bz2 Michael> Group, this patch seemed to have gotten a little munged in Michael> email. I've taken the liberty of re-diffing it, to restore Michael> white space context. Thanks. I have a few nits to pick. Jakob> + if (argc > 0 && strcmp(argv[0], "--reverse") == 0) Space before (". There are a number of these. Jakob> +/* continue in reverse direction: Jakob> + XXX: code duplicated from reverse.c */ We're trying not to add new FIXME-type comments. In this particular case I think it is ok to just drop the comment. However, if you prefer, I think you could add a new exported "make_cleanup_..." function in reverse.c. Tom