[PATCH] gdb.mi/mi-nsmoribund.exp: fix racy tests (PR testsuite/12649)

[PATCH] gdb.mi/mi-nsmoribund.exp: fix racy tests (PR testsuite/12649)

[Marek Polacek]

The problem here is again the gdb_test_multiple.  Fixed thusly.
Tested with read{,1}.  OK?

2011-06-20  Marek Polacek  <mpolacek@redhat.com>

        * gdb.mi/mi-nsmoribund.exp: Replace gdb_test_multiple with mi_gdb_test.

--- gdb/gdb/testsuite/gdb.mi/mi-nsmoribund.exp.mp       2011-05-27 14:36:48.000000000 +0200
+++ gdb/gdb/testsuite/gdb.mi/mi-nsmoribund.exp  2011-06-20 17:04:43.355984345 +0200
@@ -82,15 +82,13 @@ mi_create_breakpoint "-p 5 $srcfile:$bkp
 # Resume all threads.  Only thread 5 should report a stop.
 
 set running_re ""
-for {set i $nthreads} {$i > 0} {incr i -1} {
+for {set i $nthreads} {$i > 1} {incr i -1} {
     set running_re "$running_re\\*running,thread-id=\"$decimal\"\r\n"
 }
+# Don't append \r\n after last line.
+set running_re "$running_re\\*running,thread-id=\"$decimal\""
 
-gdb_test_multiple "-exec-continue --all" "resume all, thread specific breakpoint" {
-    -re ".*$running_re$mi_gdb_prompt" {
-       pass "resume all, thread specific breakpoint"
-    }
-}
+mi_gdb_test "-exec-continue --all" "\[^\n\]*\r\n$running_re" "resume all, thread specific breakpoint"
 
 mi_expect_stop "breakpoint-hit" "thread_function" "\[^\n\]*" "$srcfile" \
     "\[0-9\]*" {"" "disp=\"keep\""} "hit thread specific breakpoint"

Re: [PATCH] gdb.mi/mi-nsmoribund.exp: fix racy tests (PR testsuite/12649)

[Tom Tromey]

>>>>> "Marek" == Marek Polacek <mpolacek@redhat.com> writes:

Marek> 2011-06-20  Marek Polacek  <mpolacek@redhat.com>
Marek>         * gdb.mi/mi-nsmoribund.exp: Replace gdb_test_multiple with mi_gdb_test.

Marek> +mi_gdb_test "-exec-continue --all" "\[^\n\]*\r\n$running_re" "resume all, thread specific breakpoint"
 
Wrap this line, ok with that change.

Tom

Re: [PATCH] gdb.mi/mi-nsmoribund.exp: fix racy tests (PR testsuite/12649)

[Marek Polacek]

On 06/22/2011 05:17 PM, Tom Tromey wrote:
>>>>>> "Marek" == Marek Polacek <mpolacek@redhat.com> writes:
> 
> Marek> 2011-06-20  Marek Polacek  <mpolacek@redhat.com>
> Marek>         * gdb.mi/mi-nsmoribund.exp: Replace gdb_test_multiple with mi_gdb_test.
> 
> Marek> +mi_gdb_test "-exec-continue --all" "\[^\n\]*\r\n$running_re" "resume all, thread specific breakpoint"
>  
> Wrap this line, ok with that change.

Thanks, checked in:
http://sourceware.org/ml/gdb-cvs/2011-06/msg00119.html

	Marek