From: Marek Polacek <mpolacek@redhat.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: [PATCH] gdb.mi/mi-nsmoribund.exp: fix racy tests (PR testsuite/12649)
Date: Mon, 20 Jun 2011 15:12:00 -0000 [thread overview]
Message-ID: <4DFF632D.6020804@redhat.com> (raw)
The problem here is again the gdb_test_multiple. Fixed thusly.
Tested with read{,1}. OK?
2011-06-20 Marek Polacek <mpolacek@redhat.com>
* gdb.mi/mi-nsmoribund.exp: Replace gdb_test_multiple with mi_gdb_test.
--- gdb/gdb/testsuite/gdb.mi/mi-nsmoribund.exp.mp 2011-05-27 14:36:48.000000000 +0200
+++ gdb/gdb/testsuite/gdb.mi/mi-nsmoribund.exp 2011-06-20 17:04:43.355984345 +0200
@@ -82,15 +82,13 @@ mi_create_breakpoint "-p 5 $srcfile:$bkp
# Resume all threads. Only thread 5 should report a stop.
set running_re ""
-for {set i $nthreads} {$i > 0} {incr i -1} {
+for {set i $nthreads} {$i > 1} {incr i -1} {
set running_re "$running_re\\*running,thread-id=\"$decimal\"\r\n"
}
+# Don't append \r\n after last line.
+set running_re "$running_re\\*running,thread-id=\"$decimal\""
-gdb_test_multiple "-exec-continue --all" "resume all, thread specific breakpoint" {
- -re ".*$running_re$mi_gdb_prompt" {
- pass "resume all, thread specific breakpoint"
- }
-}
+mi_gdb_test "-exec-continue --all" "\[^\n\]*\r\n$running_re" "resume all, thread specific breakpoint"
mi_expect_stop "breakpoint-hit" "thread_function" "\[^\n\]*" "$srcfile" \
"\[0-9\]*" {"" "disp=\"keep\""} "hit thread specific breakpoint"
next reply other threads:[~2011-06-20 15:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-20 15:12 Marek Polacek [this message]
2011-06-22 15:17 ` Tom Tromey
2011-06-22 15:38 ` Marek Polacek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DFF632D.6020804@redhat.com \
--to=mpolacek@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox