[RFA/mi] Remove varobj enumeration XFAIL

[RFA/mi] Remove varobj enumeration XFAIL

[Keith Seitz]

[-- Attachment #1: Type: text/plain, Size: 1050 bytes --]

Hi,

mi{,2}-var-display.exp contains an XFAIL for the following test:

# Test: c_variable-7.51
# Desc: value of e
mi_gdb_test "-var-evaluate-expression e" \
	"\\^done,value=\"FIXME\"" \
	"eval variable e"

There is no bug filed for this (or for any of the other twenty-six 
setup_xfail calls in gdb.mi/), and I could find no history of why this 
was expected to fail. AFAICT, it has been this way from the beginning.

I suspect that this was xfailed because the test originally stopped in 
the beginning of the function, and there was no way to (easily?) get the 
value of the initialized enum.

But that all changed with this commit:
http://sourceware.org/ml/gdb-patches/2008-04/msg00007.html

This xfail no longer seems necessary, so I've attached a patch to fix 
the test case and remove the XFAIL.

Keith

testsuite/ChangeLog
2011-11-18  Keith Seitz  <keiths@redhat.com>

	* gdb.mi/mi-var-display.exp: Remove XFAIL for c_variable-7.51,
	-var-evaluate-expression of an enumeration and fix expected result.
	* gdb.mi/mi2-varvdisplay.exp: Likewise.

[-- Attachment #2: varobj-enum-xfail.patch --]
[-- Type: text/x-patch, Size: 1202 bytes --]

diff --git a/gdb/testsuite/gdb.mi/mi-var-display.exp b/gdb/testsuite/gdb.mi/mi-var-display.exp
index ff27407..ad5bd23 100644
--- a/gdb/testsuite/gdb.mi/mi-var-display.exp
+++ b/gdb/testsuite/gdb.mi/mi-var-display.exp
@@ -529,13 +529,11 @@ mi_list_varobj_children anons {
 # Desc: create enum e
 mi_create_varobj e e "create local variable e"
 
-setup_xfail "*-*-*"
 # Test: c_variable-7.51
 # Desc: value of e
 mi_gdb_test "-var-evaluate-expression e" \
-	"\\^done,value=\"FIXME\"" \
+	"\\^done,value=\"bar\"" \
 	"eval variable e"
-clear_xfail "*-*-*"
 
 # Test: c_variable-7.52
 # Desc: type of e
diff --git a/gdb/testsuite/gdb.mi/mi2-var-display.exp b/gdb/testsuite/gdb.mi/mi2-var-display.exp
index 828614b..2fb0f47 100644
--- a/gdb/testsuite/gdb.mi/mi2-var-display.exp
+++ b/gdb/testsuite/gdb.mi/mi2-var-display.exp
@@ -528,13 +528,11 @@ mi_list_varobj_children anons {
 # Desc: create enum e
 mi_create_varobj e e "create local variable e"
 
-setup_xfail "*-*-*"
 # Test: c_variable-7.51
 # Desc: value of e
 mi_gdb_test "-var-evaluate-expression e" \
-	"\\^done,value=\"FIXME\"" \
+	"\\^done,value=\"bar\"" \
 	"eval variable e"
-clear_xfail "*-*-*"
 
 # Test: c_variable-7.52
 # Desc: type of e

Re: [RFA/mi] Remove varobj enumeration XFAIL

[Tom Tromey]

>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:

Keith> 2011-11-18  Keith Seitz  <keiths@redhat.com>
Keith> 	* gdb.mi/mi-var-display.exp: Remove XFAIL for c_variable-7.51,
Keith> 	-var-evaluate-expression of an enumeration and fix expected result.
Keith> 	* gdb.mi/mi2-varvdisplay.exp: Likewise.

This is ok.  Thanks.

Tom

Re: [RFA/mi] Remove varobj enumeration XFAIL

[Keith Seitz]

On 11/21/2011 11:52 AM, Tom Tromey wrote:
>>>>>> "Keith" == Keith Seitz<keiths@redhat.com>  writes:
>
> Keith>  2011-11-18  Keith Seitz<keiths@redhat.com>
> Keith>  	* gdb.mi/mi-var-display.exp: Remove XFAIL for c_variable-7.51,
> Keith>  	-var-evaluate-expression of an enumeration and fix expected result.
> Keith>  	* gdb.mi/mi2-varvdisplay.exp: Likewise.
>
> This is ok.  Thanks.

Committed. Thank you for taking a look.

Keith