From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4937 invoked by alias); 18 Nov 2011 20:33:39 -0000 Received: (qmail 4928 invoked by uid 22791); 18 Nov 2011 20:33:38 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 18 Nov 2011 20:33:15 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pAIKXFTN024658 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 18 Nov 2011 15:33:15 -0500 Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id pAIKXCUm028344 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO) for ; Fri, 18 Nov 2011 15:33:14 -0500 Message-ID: <4EC6C108.9030705@redhat.com> Date: Fri, 18 Nov 2011 20:33:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0) Gecko/20110927 Thunderbird/7.0 MIME-Version: 1.0 To: "gdb-patches@sourceware.org ml" Subject: [RFA/mi] Remove varobj enumeration XFAIL Content-Type: multipart/mixed; boundary="------------060703050305010102040605" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00511.txt.bz2 This is a multi-part message in MIME format. --------------060703050305010102040605 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 1050 Hi, mi{,2}-var-display.exp contains an XFAIL for the following test: # Test: c_variable-7.51 # Desc: value of e mi_gdb_test "-var-evaluate-expression e" \ "\\^done,value=\"FIXME\"" \ "eval variable e" There is no bug filed for this (or for any of the other twenty-six setup_xfail calls in gdb.mi/), and I could find no history of why this was expected to fail. AFAICT, it has been this way from the beginning. I suspect that this was xfailed because the test originally stopped in the beginning of the function, and there was no way to (easily?) get the value of the initialized enum. But that all changed with this commit: http://sourceware.org/ml/gdb-patches/2008-04/msg00007.html This xfail no longer seems necessary, so I've attached a patch to fix the test case and remove the XFAIL. Keith testsuite/ChangeLog 2011-11-18 Keith Seitz * gdb.mi/mi-var-display.exp: Remove XFAIL for c_variable-7.51, -var-evaluate-expression of an enumeration and fix expected result. * gdb.mi/mi2-varvdisplay.exp: Likewise. --------------060703050305010102040605 Content-Type: text/x-patch; name="varobj-enum-xfail.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="varobj-enum-xfail.patch" Content-length: 1202 diff --git a/gdb/testsuite/gdb.mi/mi-var-display.exp b/gdb/testsuite/gdb.mi/mi-var-display.exp index ff27407..ad5bd23 100644 --- a/gdb/testsuite/gdb.mi/mi-var-display.exp +++ b/gdb/testsuite/gdb.mi/mi-var-display.exp @@ -529,13 +529,11 @@ mi_list_varobj_children anons { # Desc: create enum e mi_create_varobj e e "create local variable e" -setup_xfail "*-*-*" # Test: c_variable-7.51 # Desc: value of e mi_gdb_test "-var-evaluate-expression e" \ - "\\^done,value=\"FIXME\"" \ + "\\^done,value=\"bar\"" \ "eval variable e" -clear_xfail "*-*-*" # Test: c_variable-7.52 # Desc: type of e diff --git a/gdb/testsuite/gdb.mi/mi2-var-display.exp b/gdb/testsuite/gdb.mi/mi2-var-display.exp index 828614b..2fb0f47 100644 --- a/gdb/testsuite/gdb.mi/mi2-var-display.exp +++ b/gdb/testsuite/gdb.mi/mi2-var-display.exp @@ -528,13 +528,11 @@ mi_list_varobj_children anons { # Desc: create enum e mi_create_varobj e e "create local variable e" -setup_xfail "*-*-*" # Test: c_variable-7.51 # Desc: value of e mi_gdb_test "-var-evaluate-expression e" \ - "\\^done,value=\"FIXME\"" \ + "\\^done,value=\"bar\"" \ "eval variable e" -clear_xfail "*-*-*" # Test: c_variable-7.52 # Desc: type of e --------------060703050305010102040605--