From: Tom Tromey <tromey@redhat.com>
To: "Ulrich Weigand" <uweigand@de.ibm.com>
Cc: jan.kratochvil@redhat.com (Jan Kratochvil),
gdb-patches@sourceware.org,
brobecker@adacore.com (Joel Brobecker),
alves.ped@gmail.com (Pedro Alves)
Subject: Re: [patch+7.4] reread.exp 7.3->7.4 regression
Date: Mon, 19 Dec 2011 19:05:00 -0000 [thread overview]
Message-ID: <m3hb0wo01t.fsf@fleche.redhat.com> (raw)
In-Reply-To: <201112191030.pBJAUsf4028428@d06av02.portsmouth.uk.ibm.com> (Ulrich Weigand's message of "Mon, 19 Dec 2011 11:30:54 +0100 (CET)")
>>>>> "Ulrich" == Ulrich Weigand <uweigand@de.ibm.com> writes:
Ulrich> I really think this ought to be fixed in reread_symbols; freeing the old
Ulrich> OBFD needs to be done *after* all the callbacks to cleanup objfile data
Ulrich> have completed.
I agree.
Also see free_objfile, which calls objfile_free_data before closing the
BFD.
This, btw, is the main reason that I like Jan's old patch to unify
re-reading with freeing -- it automatically means consistency.
Perhaps Pedro's problems with that patch could be alleviated by having
"destroy in place" and "initialize in place" functions that both
free_objfile and reread_symbols could use.
Tom
next prev parent reply other threads:[~2011-12-19 19:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-18 12:00 Jan Kratochvil
2011-12-19 4:17 ` Joel Brobecker
2011-12-19 9:54 ` Jan Kratochvil
2011-12-19 10:13 ` Joel Brobecker
2011-12-19 10:31 ` Jan Kratochvil
2011-12-19 10:32 ` Ulrich Weigand
2011-12-19 19:05 ` Tom Tromey [this message]
2011-12-19 19:12 ` Jan Kratochvil
2011-12-19 20:02 ` Tom Tromey
2011-12-19 19:47 ` Jan Kratochvil
2011-12-19 21:49 ` Ulrich Weigand
2011-12-19 22:56 ` [commit+7.4] " Jan Kratochvil
2011-12-21 11:46 ` [patch] reread_symbols observer_notify_new_objfile - fix ARM unwinding after reread [Re: [patch+7.4] reread.exp 7.3->7.4 regression] Jan Kratochvil
2011-12-21 13:13 ` [patch] reread_symbols observer_notify_new_objfile - fix ARM unwinding after reread [Re: [patch+7.4] reread.exp 7.3->7.4 regres Ulrich Weigand
2011-12-21 14:27 ` [commit] [patch] reread_symbols observer_notify_new_objfile - fix ARM unwinding after reread Jan Kratochvil
2011-12-19 15:28 ` [patch+7.4] reread.exp 7.3->7.4 regression Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3hb0wo01t.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=alves.ped@gmail.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox