Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org, Pedro Alves <alves.ped@gmail.com>
Subject: Re: [patch+7.4] reread.exp 7.3->7.4 regression
Date: Mon, 19 Dec 2011 10:13:00 -0000	[thread overview]
Message-ID: <20111219095427.GT21915@adacore.com> (raw)
In-Reply-To: <20111219093131.GA3484@host2.jankratochvil.net>

> The freeing is not the only problem.  The same problem applies on the lines
> accessing the elements, those statements can also crash now without this
> patch.  It is just not shown in this crash backtrace.

Ugh, this is really nasty. I know you've delved into this more than
I have, so I am Ok with your proposed initial work around. Others
might have an opinion too. Is it worth labeling all the places that
we ended up modifying? I guess not - they all reference the new
field which is clearly documented as being here to work around
a deficiency in the design.

I think this problem ties us with the problem Tom was trying to
figure out, where BFD opens and closes bfd's without telling us.

-- 
Joel


  reply	other threads:[~2011-12-19  9:54 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-18 12:00 Jan Kratochvil
2011-12-19  4:17 ` Joel Brobecker
2011-12-19  9:54   ` Jan Kratochvil
2011-12-19 10:13     ` Joel Brobecker [this message]
2011-12-19 10:31       ` Jan Kratochvil
2011-12-19 10:32 ` Ulrich Weigand
2011-12-19 19:05   ` Tom Tromey
2011-12-19 19:12     ` Jan Kratochvil
2011-12-19 20:02       ` Tom Tromey
2011-12-19 19:47   ` Jan Kratochvil
2011-12-19 21:49     ` Ulrich Weigand
2011-12-19 22:56       ` [commit+7.4] " Jan Kratochvil
2011-12-21 11:46   ` [patch] reread_symbols observer_notify_new_objfile - fix ARM unwinding after reread [Re: [patch+7.4] reread.exp 7.3->7.4 regression] Jan Kratochvil
2011-12-21 13:13     ` [patch] reread_symbols observer_notify_new_objfile - fix ARM unwinding after reread [Re: [patch+7.4] reread.exp 7.3->7.4 regres Ulrich Weigand
2011-12-21 14:27       ` [commit] [patch] reread_symbols observer_notify_new_objfile - fix ARM unwinding after reread Jan Kratochvil
2011-12-19 15:28 ` [patch+7.4] reread.exp 7.3->7.4 regression Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111219095427.GT21915@adacore.com \
    --to=brobecker@adacore.com \
    --cc=alves.ped@gmail.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox