From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 354 invoked by alias); 19 Dec 2011 19:05:16 -0000 Received: (qmail 345 invoked by uid 22791); 19 Dec 2011 19:05:14 -0000 X-SWARE-Spam-Status: No, hits=-5.7 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,TW_BJ X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 19 Dec 2011 19:04:58 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pBJJ4XN1021907 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 19 Dec 2011 14:04:33 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id pBJJ4XMZ008824; Mon, 19 Dec 2011 14:04:33 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id pBJJ4UZX023268; Mon, 19 Dec 2011 14:04:31 -0500 From: Tom Tromey To: "Ulrich Weigand" Cc: jan.kratochvil@redhat.com (Jan Kratochvil), gdb-patches@sourceware.org, brobecker@adacore.com (Joel Brobecker), alves.ped@gmail.com (Pedro Alves) Subject: Re: [patch+7.4] reread.exp 7.3->7.4 regression References: <20111218115343.GB22534@host2.jankratochvil.net> <201112191030.pBJAUsf4028428@d06av02.portsmouth.uk.ibm.com> Date: Mon, 19 Dec 2011 19:05:00 -0000 In-Reply-To: <201112191030.pBJAUsf4028428@d06av02.portsmouth.uk.ibm.com> (Ulrich Weigand's message of "Mon, 19 Dec 2011 11:30:54 +0100 (CET)") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-12/txt/msg00644.txt.bz2 >>>>> "Ulrich" == Ulrich Weigand writes: Ulrich> I really think this ought to be fixed in reread_symbols; freeing the old Ulrich> OBFD needs to be done *after* all the callbacks to cleanup objfile data Ulrich> have completed. I agree. Also see free_objfile, which calls objfile_free_data before closing the BFD. This, btw, is the main reason that I like Jan's old patch to unify re-reading with freeing -- it automatically means consistency. Perhaps Pedro's problems with that patch could be alleviated by having "destroy in place" and "initialize in place" functions that both free_objfile and reread_symbols could use. Tom