From: Andreas Arnez <arnez@linux.vnet.ibm.com>
To: Simon Marchi <simon.marchi@ericsson.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH 2/3] Testsuite: Rename "end()" to avoid libinproctrace C++ symbol clash
Date: Mon, 19 Mar 2018 12:15:00 -0000 [thread overview]
Message-ID: <m3h8pcw9bm.fsf@oc1027705133.ibm.com> (raw)
In-Reply-To: <a31c0b89-dbcf-fb40-d8ec-aee748e61e3c@ericsson.com> (Simon Marchi's message of "Fri, 16 Mar 2018 17:57:26 -0400")
On Fri, Mar 16 2018, Simon Marchi wrote:
> Since the gdb_breakpoint proc accepts the multi-location printout, we may
> not even need the "qualified", just using gdb_breakpoint would be sufficient.
> But I think it's not bad either to use "qualified", as it makes the test more
> robust. It makes sure the test doesn't stop on another random end function/method.
Right, these random breakpoints could hit us badly in the future.
> So this LGTM, thanks.
Thanks, pushed.
--
Andreas
next prev parent reply other threads:[~2018-03-19 12:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-14 16:12 [PATCH 0/3] Some gdbserver test suite fixes Andreas Arnez
2018-03-14 16:13 ` [PATCH 2/3] Testsuite: Rename "end()" to avoid libinproctrace C++ symbol clash Andreas Arnez
2018-03-15 21:58 ` Simon Marchi
2018-03-16 19:47 ` Andreas Arnez
2018-03-16 21:57 ` Simon Marchi
2018-03-19 12:15 ` Andreas Arnez [this message]
2018-03-26 14:44 ` Pedro Alves
2018-03-14 16:13 ` [PATCH 1/3] Fix tspeed test case: copy libinproctrace to target Andreas Arnez
2018-03-15 21:40 ` Simon Marchi
2018-03-16 19:41 ` Andreas Arnez
2018-03-14 16:13 ` [PATCH 3/3] Fix a FAIL in attach.exp under native-extended-gdbserver Andreas Arnez
2018-03-15 22:17 ` Simon Marchi
2018-04-25 9:32 ` Andreas Arnez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3h8pcw9bm.fsf@oc1027705133.ibm.com \
--to=arnez@linux.vnet.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox