From: Simon Marchi <simon.marchi@ericsson.com>
To: Andreas Arnez <arnez@linux.vnet.ibm.com>, <gdb-patches@sourceware.org>
Subject: Re: [PATCH 1/3] Fix tspeed test case: copy libinproctrace to target
Date: Thu, 15 Mar 2018 21:40:00 -0000 [thread overview]
Message-ID: <b10e14a6-51c4-af04-5a80-622567683c78@ericsson.com> (raw)
In-Reply-To: <1521043903-18837-2-git-send-email-arnez@linux.vnet.ibm.com>
On 2018-03-14 12:11 PM, Andreas Arnez wrote:
> The tspeed test case does not execute correctly because libinproctrace.so
> is not copied to the target. This is fixed.
>
> gdb/testsuite/ChangeLog:
>
> * gdb.trace/tspeed.exp: Add invocation of gdb_load_shlib to ensure
> that libinproctrace is copied to the target.
> ---
> gdb/testsuite/gdb.trace/tspeed.exp | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/gdb/testsuite/gdb.trace/tspeed.exp b/gdb/testsuite/gdb.trace/tspeed.exp
> index d53608c51b..ecd36d2d9b 100644
> --- a/gdb/testsuite/gdb.trace/tspeed.exp
> +++ b/gdb/testsuite/gdb.trace/tspeed.exp
> @@ -19,6 +19,7 @@ standard_testfile
> set executable $testfile
>
> set ipalib [get_in_proc_agent]
> +gdb_load_shlib $ipalib
>
> if { [gdb_compile "$srcdir/$subdir/$srcfile" $binfile \
> executable [concat {debug nowarnings c} shlib=$ipalib]] != "" } {
>
LGTM.
Simon
next prev parent reply other threads:[~2018-03-15 21:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-14 16:12 [PATCH 0/3] Some gdbserver test suite fixes Andreas Arnez
2018-03-14 16:13 ` [PATCH 2/3] Testsuite: Rename "end()" to avoid libinproctrace C++ symbol clash Andreas Arnez
2018-03-15 21:58 ` Simon Marchi
2018-03-16 19:47 ` Andreas Arnez
2018-03-16 21:57 ` Simon Marchi
2018-03-19 12:15 ` Andreas Arnez
2018-03-26 14:44 ` Pedro Alves
2018-03-14 16:13 ` [PATCH 1/3] Fix tspeed test case: copy libinproctrace to target Andreas Arnez
2018-03-15 21:40 ` Simon Marchi [this message]
2018-03-16 19:41 ` Andreas Arnez
2018-03-14 16:13 ` [PATCH 3/3] Fix a FAIL in attach.exp under native-extended-gdbserver Andreas Arnez
2018-03-15 22:17 ` Simon Marchi
2018-04-25 9:32 ` Andreas Arnez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b10e14a6-51c4-af04-5a80-622567683c78@ericsson.com \
--to=simon.marchi@ericsson.com \
--cc=arnez@linux.vnet.ibm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox