Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Doug Evans <dje@google.com>
Cc: Pedro Alves <pedro@codesourcery.com>,
	Eli Zaretskii <eliz@gnu.org>,
	        gdb-patches@sourceware.org
Subject: Re: [RFA] Fix too many "no debugging symbols found" warnings.
Date: Thu, 27 Aug 2009 19:11:00 -0000	[thread overview]
Message-ID: <m3fxbdw1qn.fsf@fleche.redhat.com> (raw)
In-Reply-To: <e394668d0908241413gac76a36j434507ebd7408b1d@mail.gmail.com> 	(Doug Evans's message of "Mon, 24 Aug 2009 14:13:49 -0700")

>>>>> "Doug" == Doug Evans <dje@google.com> writes:

Tom> This particular function seems overdue for ui-out-ification.
Tom> This would let us keep the old version for MI[12], and then properly
Tom> evolve the output for future versions MI.

Doug> Is this what you had in mind?

Yes, thanks.

FWIW that was just a drive-by complaint of mine... I will try to stop
doing that, I didn't intend to get you to do this.

Doug> +  ui_out_table_header (uiout, addr_width - 1, ui_left, "From", "From");
Doug> +  ui_out_table_header (uiout, addr_width - 1, ui_left, "To", "To");
Doug> +  ui_out_table_header (uiout, 12 - 1, ui_left, "SymsRead", "Syms Read");

It seems to be GDB style that column names (the first string arg) should
be lowercase, not camelcase.  Generally they use "-" and not "_" as well
(I only saw one exception).

Doug> +	  ui_out_field_string (uiout, "From", "");
Doug> +	  ui_out_field_string (uiout, "To", "");

Probably use ui_out_field_skip here.

Tom


  parent reply	other threads:[~2009-08-27 18:28 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-23 23:24 Doug Evans
2009-05-25  3:20 ` Eli Zaretskii
2009-05-25 16:07   ` Doug Evans
2009-06-04 20:34     ` Tom Tromey
2009-06-04 21:20       ` Pedro Alves
2009-06-05 18:19         ` Tom Tromey
2009-06-05 18:49           ` Pedro Alves
2009-06-05 22:18             ` Tom Tromey
2009-06-19  0:48               ` Doug Evans
2009-06-22 17:54                 ` Tom Tromey
2009-06-22 19:35                   ` Pedro Alves
2009-06-30 21:49                     ` Doug Evans
2009-06-30 21:55                       ` Pedro Alves
2009-06-30 22:20                         ` Doug Evans
2009-07-01  2:29                           ` Tom Tromey
2009-07-01  3:13                       ` Eli Zaretskii
2009-07-01  3:47                         ` Doug Evans
2009-07-01 17:48                           ` Eli Zaretskii
2009-07-01 17:53                             ` Doug Evans
2009-07-01 18:01                               ` Pedro Alves
2009-07-01 19:55                                 ` Doug Evans
2009-07-02 13:26                                   ` Pedro Alves
2009-07-02 20:08                                     ` Doug Evans
2009-07-02 22:43                                       ` Pedro Alves
2009-07-11  4:22                                         ` Doug Evans
2009-07-20 13:21                                           ` Pedro Alves
2009-07-23 18:57                                             ` Doug Evans
2009-07-27 17:15                                               ` Tom Tromey
2009-08-24 22:02                                                 ` Doug Evans
2009-08-25  3:47                                                   ` Eli Zaretskii
2009-08-27 19:11                                                   ` Tom Tromey [this message]
2009-08-27 23:39                                                     ` Doug Evans

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3fxbdw1qn.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=dje@google.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox