From: Doug Evans <dje@google.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: Eli Zaretskii <eliz@gnu.org>,
tromey@redhat.com, gdb-patches@sourceware.org
Subject: Re: [RFA] Fix too many "no debugging symbols found" warnings.
Date: Wed, 01 Jul 2009 19:55:00 -0000 [thread overview]
Message-ID: <e394668d0907011255x69476766y92a86e0c63d76267@mail.gmail.com> (raw)
In-Reply-To: <200907011902.19110.pedro@codesourcery.com>
On Wed, Jul 1, 2009 at 11:02 AM, Pedro Alves<pedro@codesourcery.com> wrote:
> On Wednesday 01 July 2009 18:52:50, Doug Evans wrote:
>> Does anyone have any other concerns with the patch?
>
> Does this mean that there will be no way anymore to say
> that you don't want symbol loading info? I was assuming
> we'd still have that option. :-/
>
> I find "set print symbol-loading-warnings" a bit
> misnamed, since this isn't about *all* warnings. In fact,
> it's about *no* symbols. I don't really want to get
> bishedy, but, why was it that keeping the existing
> option and adding a new one wasn't good?
>
> set print symbol-loading on|off
> set print no-symbols-found-warnings on|off
First, there's a bit of history here.
I added "print symbol-loading" to be able to turn off the "no
debugging symbols found" verbosity, but it wasn't working out the way
I wanted - it was all or nothing when what I really wanted was a way
to turn off the verbosity for automatically loaded libraries (for
which there can be 100's or even >1000) and not, for example,
executables, or anything manually done from the command line (one can
think of executables as falling in this category).
Secondly, it's not clear to me that users would ever want to turn off
messages for things they do from the command line. i.e. "if
(from_tty)" is a sufficient check for these particular messages and
that's what 6.8 does (well, it also tests info_verbose). I realize
scripts might cause an excess of verbosity from command-line related
symbol loading, but I don't know of any existing examples of that, so
I didn't want to keep two options if just for that.
Thirdly, symbol-loading-warnings is a compatible renaming of
symbol-loading - any distributions that have already shipped "print
symbol-loading" will see a minor change in behavior in 7.0 but nothing
will break. [I realize this isn't a strong argument to some. I don't
have a strong opinion on the option name choice, I just mention it as
it did factor into the choice.]
Fourth, gdb doesn't print symbol loading messages if (!from_tty &&
!info_verbose). Except for the "no debugging symbols found" warning,
"print symbol-loading" doesn't apply unless either of those flags are
true (in current cvs).
Fifth, in the past I've observed pushback on unnecessary options, and
so here I was trying to "go with the flow".
Put this all together and that's why the patch is the way it is.
Ultimately, I don't have a strong opinion on having both options. I
do have a strong opinion on providing an option to the user to let
them turn off the "no debugging symbols found" message (and other such
messages) from automatically loaded libraries.
Thoughts?
next prev parent reply other threads:[~2009-07-01 19:55 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-23 23:24 Doug Evans
2009-05-25 3:20 ` Eli Zaretskii
2009-05-25 16:07 ` Doug Evans
2009-06-04 20:34 ` Tom Tromey
2009-06-04 21:20 ` Pedro Alves
2009-06-05 18:19 ` Tom Tromey
2009-06-05 18:49 ` Pedro Alves
2009-06-05 22:18 ` Tom Tromey
2009-06-19 0:48 ` Doug Evans
2009-06-22 17:54 ` Tom Tromey
2009-06-22 19:35 ` Pedro Alves
2009-06-30 21:49 ` Doug Evans
2009-06-30 21:55 ` Pedro Alves
2009-06-30 22:20 ` Doug Evans
2009-07-01 2:29 ` Tom Tromey
2009-07-01 3:13 ` Eli Zaretskii
2009-07-01 3:47 ` Doug Evans
2009-07-01 17:48 ` Eli Zaretskii
2009-07-01 17:53 ` Doug Evans
2009-07-01 18:01 ` Pedro Alves
2009-07-01 19:55 ` Doug Evans [this message]
2009-07-02 13:26 ` Pedro Alves
2009-07-02 20:08 ` Doug Evans
2009-07-02 22:43 ` Pedro Alves
2009-07-11 4:22 ` Doug Evans
2009-07-20 13:21 ` Pedro Alves
2009-07-23 18:57 ` Doug Evans
2009-07-27 17:15 ` Tom Tromey
2009-08-24 22:02 ` Doug Evans
2009-08-25 3:47 ` Eli Zaretskii
2009-08-27 19:11 ` Tom Tromey
2009-08-27 23:39 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e394668d0907011255x69476766y92a86e0c63d76267@mail.gmail.com \
--to=dje@google.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox