From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18260 invoked by alias); 27 Aug 2009 18:28:35 -0000 Received: (qmail 18246 invoked by uid 22791); 27 Aug 2009 18:28:35 -0000 X-SWARE-Spam-Status: No, hits=0.2 required=5.0 tests=AWL,BAYES_00,KAM_STOCKTIP,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 27 Aug 2009 18:28:29 +0000 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n7RIS3ZS028424; Thu, 27 Aug 2009 14:28:03 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id n7RIS3mp002185; Thu, 27 Aug 2009 14:28:03 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n7RIS1M6025658; Thu, 27 Aug 2009 14:28:02 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 59F133782A9; Thu, 27 Aug 2009 12:28:01 -0600 (MDT) From: Tom Tromey To: Doug Evans Cc: Pedro Alves , Eli Zaretskii , gdb-patches@sourceware.org Subject: Re: [RFA] Fix too many "no debugging symbols found" warnings. References: <20090523232414.BED2B846C2@localhost> <200907022344.12495.pedro@codesourcery.com> <200907201402.47393.pedro@codesourcery.com> Reply-To: Tom Tromey Date: Thu, 27 Aug 2009 19:11:00 -0000 In-Reply-To: (Doug Evans's message of "Mon, 24 Aug 2009 14:13:49 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-08/txt/msg00489.txt.bz2 >>>>> "Doug" == Doug Evans writes: Tom> This particular function seems overdue for ui-out-ification. Tom> This would let us keep the old version for MI[12], and then properly Tom> evolve the output for future versions MI. Doug> Is this what you had in mind? Yes, thanks. FWIW that was just a drive-by complaint of mine... I will try to stop doing that, I didn't intend to get you to do this. Doug> + ui_out_table_header (uiout, addr_width - 1, ui_left, "From", "From"); Doug> + ui_out_table_header (uiout, addr_width - 1, ui_left, "To", "To"); Doug> + ui_out_table_header (uiout, 12 - 1, ui_left, "SymsRead", "Syms Read"); It seems to be GDB style that column names (the first string arg) should be lowercase, not camelcase. Generally they use "-" and not "_" as well (I only saw one exception). Doug> + ui_out_field_string (uiout, "From", ""); Doug> + ui_out_field_string (uiout, "To", ""); Probably use ui_out_field_skip here. Tom