From: Tom Tromey <tromey@redhat.com>
To: Cary Coutant <ccoutant@google.com>
Cc: gdb-patches@sourceware.org, Doug Evans <dje@google.com>
Subject: Re: [patch] Allow dummy CUs created by incremental linker
Date: Wed, 19 Oct 2011 15:27:00 -0000 [thread overview]
Message-ID: <m3ehy92gfk.fsf@fleche.redhat.com> (raw)
In-Reply-To: <CAHACq4q74NiMgxg=J7b0HCotZfJtwdfxHhCnkfwwvWu=FMgJDg@mail.gmail.com> (Cary Coutant's message of "Tue, 18 Oct 2011 17:30:16 -0700")
>>>>> "Cary" == Cary Coutant <ccoutant@google.com> writes:
Cary> With the new incremental linking support in gold, we leave patch space
Cary> in the file at link time, and use that patch space for incremental
Cary> updates. If the file has debug info, that means that the debug info
Cary> might have "holes" in it. Because the debugger can't deal with
Cary> arbitrary holes in the debug info, gold fills the holes with dummy
Cary> compilation units, where each dummy CU consists of a compilation unit
Cary> header whose length field cover the hole, and the rest of the space
Cary> filled with zeroes. This patch updated gdb to tolerate these dummy
Cary> CUs, by checking for an empty CU before attempting to read the DIEs.
Thanks.
Cary> +static unsigned int
Cary> +peek_abbrev_code (bfd *abfd, gdb_byte *info_ptr)
Cary> +{
Cary> + unsigned int bytes_read;
Cary> + return read_unsigned_leb128 (abfd, info_ptr, &bytes_read);
Our coding style requires a newline after the declarations.
Ok with that change.
Tom
next prev parent reply other threads:[~2011-10-19 14:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-19 0:44 Cary Coutant
2011-10-19 15:27 ` Tom Tromey [this message]
2011-10-19 15:52 ` Cary Coutant
2011-10-20 15:00 ` Regression for .debug_types [Re: [patch] Allow dummy CUs created by incremental linker] Jan Kratochvil
2011-10-20 19:16 ` Cary Coutant
2011-10-20 22:35 ` Cary Coutant
2011-10-21 0:00 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3ehy92gfk.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=ccoutant@google.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox